You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Ondra Žižka (JIRA)" <ji...@apache.org> on 2012/09/15 02:30:07 UTC

[jira] [Created] (WICKET-4765) Skip some validations inside

Ondra Žižka created WICKET-4765:
-----------------------------------

             Summary: Skip some validations inside <wicket:remove>
                 Key: WICKET-4765
                 URL: https://issues.apache.org/jira/browse/WICKET-4765
             Project: Wicket
          Issue Type: Improvement
          Components: wicket
    Affects Versions: 1.5.8
            Reporter: Ondra Žižka


When {{<wicket:remove>}} contains invalid {{wicket:id=""}}, Wicket fails with:

{code}
Last cause: The wicket:id attribute value must not be empty. May be unmatched quotes?!? '<input type="text" wicket:id=""/>' (line 55, column 54)
{code}

{code}
                <wicket:remove>
                <tr>
                    <td>:</td>
                    <td><input type="text" wicket:id=""/></td>
                </tr>
                </wicket:remove>
{code}

Wouldn't it be wiser to ignore such things inside of it?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (WICKET-4765) Skip some validations inside

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13456894#comment-13456894 ] 

Martin Grigorov commented on WICKET-4765:
-----------------------------------------

I'm not sure about this improvement.
Currently the thrown exception notifies you that you expect to have a component in an area which is discarded/removed. So it informs you that there is something that wont happen. 
                
> Skip some validations inside <wicket:remove>
> --------------------------------------------
>
>                 Key: WICKET-4765
>                 URL: https://issues.apache.org/jira/browse/WICKET-4765
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5.8
>            Reporter: Ondra Žižka
>
> When {{<wicket:remove>}} contains invalid {{wicket:id=""}}, Wicket fails with:
> {code}
> Last cause: The wicket:id attribute value must not be empty. May be unmatched quotes?!? '<input type="text" wicket:id=""/>' (line 55, column 54)
> {code}
> {code}
>                 <wicket:remove>
>                 <tr>
>                     <td>:</td>
>                     <td><input type="text" wicket:id=""/></td>
>                 </tr>
>                 </wicket:remove>
> {code}
> Wouldn't it be wiser to ignore such things inside of it?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (WICKET-4765) Skip some validations inside

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-4765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov resolved WICKET-4765.
-------------------------------------

    Resolution: Won't Fix

Closing as "Won't fix".
The current behavior helps you to identify that you may have an actual error in your markup.
                
> Skip some validations inside <wicket:remove>
> --------------------------------------------
>
>                 Key: WICKET-4765
>                 URL: https://issues.apache.org/jira/browse/WICKET-4765
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5.8
>            Reporter: Ondra Žižka
>
> When {{<wicket:remove>}} contains invalid {{wicket:id=""}}, Wicket fails with:
> {code}
> Last cause: The wicket:id attribute value must not be empty. May be unmatched quotes?!? '<input type="text" wicket:id=""/>' (line 55, column 54)
> {code}
> {code}
>                 <wicket:remove>
>                 <tr>
>                     <td>:</td>
>                     <td><input type="text" wicket:id=""/></td>
>                 </tr>
>                 </wicket:remove>
> {code}
> Wouldn't it be wiser to ignore such things inside of it?

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira