You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by "kiranchavala (via GitHub)" <gi...@apache.org> on 2024/01/25 11:26:59 UTC
[PR] added cluster_id parameter and modified hostid to host_id [cloudstack-terraform-provider]
kiranchavala opened a new pull request, #79:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/79
This PR fixes #61 ,
Added cluster_id parmeter to cloudstack_instance resource
https://github.com/apache/cloudstack-terraform-provider/issues/61
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] added cluster_id parameter and modified hostid to host_id [cloudstack-terraform-provider]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #79:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/79#discussion_r1466261875
##########
cloudstack/resource_cloudstack_instance.go:
##########
@@ -144,7 +144,12 @@ func resourceCloudStackInstance() *schema.Resource {
Optional: true,
},
- "hostid": {
+ "host_id": {
Review Comment:
this can impact existing users using hostid param, doc/release notes update needed. cc @kiranchavala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] added cluster_id parameter and modified hostid to host_id [cloudstack-terraform-provider]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on code in PR #79:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/79#discussion_r1466275228
##########
cloudstack/resource_cloudstack_instance.go:
##########
@@ -144,7 +144,12 @@ func resourceCloudStackInstance() *schema.Resource {
Optional: true,
},
- "hostid": {
+ "host_id": {
Review Comment:
ok @kiranchavala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] added cluster_id parameter and modified hostid to host_id [cloudstack-terraform-provider]
Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on code in PR #79:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/79#discussion_r1466273040
##########
cloudstack/resource_cloudstack_instance.go:
##########
@@ -144,7 +144,12 @@ func resourceCloudStackInstance() *schema.Resource {
Optional: true,
},
- "hostid": {
+ "host_id": {
Review Comment:
@sureshanaparti, I think existing users are not affected as the hostid param was not present in 0.4.0 release.
hostid fix is also planned for 0.5.0 release, I just changed it from hostid to host_id to follow the convention
https://github.com/apache/cloudstack-terraform-provider/pull/52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] added cluster_id parameter and modified hostid to host_id [cloudstack-terraform-provider]
Posted by "rohityadavcloud (via GitHub)" <gi...@apache.org>.
rohityadavcloud merged PR #79:
URL: https://github.com/apache/cloudstack-terraform-provider/pull/79
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org