You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Martin Gilday (JIRA)" <ji...@apache.org> on 2009/11/08 16:20:53 UTC
[jira] Created: (CAMEL-2148) DataFormat for Google Protocol Buffers
DataFormat for Google Protocol Buffers
--------------------------------------
Key: CAMEL-2148
URL: https://issues.apache.org/activemq/browse/CAMEL-2148
Project: Apache Camel
Issue Type: New Feature
Reporter: Martin Gilday
DataFormat for Google Protocol Buffers aka protobuf
http://code.google.com/apis/protocolbuffers/
http://code.google.com/p/protobuf/
The Google project uses 'New BSD License'. Is this a compatible license? Camel Extra seems to just be for GPL style licenses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2148) DataFormat for Google Protocol
Buffers
Posted by "Martin Gilday (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56540#action_56540 ]
Martin Gilday commented on CAMEL-2148:
--------------------------------------
Started the documentation http://cwiki.apache.org/confluence/display/CAMEL/Protobuf
Just requires the DSL sections completing once we know the options we will provide.
> DataFormat for Google Protocol Buffers
> --------------------------------------
>
> Key: CAMEL-2148
> URL: https://issues.apache.org/activemq/browse/CAMEL-2148
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Martin Gilday
> Assignee: Willem Jiang
> Fix For: 2.2.0
>
> Attachments: camel-protobuf.zip
>
>
> DataFormat for Google Protocol Buffers aka protobuf
> http://code.google.com/apis/protocolbuffers/
> http://code.google.com/p/protobuf/
> The Google project uses 'New BSD License'. Is this a compatible license? Camel Extra seems to just be for GPL style licenses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2148) DataFormat for Google Protocol
Buffers
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56522#action_56522 ]
Willem Jiang commented on CAMEL-2148:
-------------------------------------
yeah, using CamleContext.resolveClass is a better idea ;)
Current the google jar is not OSGI ready, we need to wrap it in the SMX repo.
> DataFormat for Google Protocol Buffers
> --------------------------------------
>
> Key: CAMEL-2148
> URL: https://issues.apache.org/activemq/browse/CAMEL-2148
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Martin Gilday
> Assignee: Willem Jiang
> Fix For: 2.2.0
>
> Attachments: camel-protobuf.zip
>
>
> DataFormat for Google Protocol Buffers aka protobuf
> http://code.google.com/apis/protocolbuffers/
> http://code.google.com/p/protobuf/
> The Google project uses 'New BSD License'. Is this a compatible license? Camel Extra seems to just be for GPL style licenses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CAMEL-2148) DataFormat for Google Protocol
Buffers
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang resolved CAMEL-2148.
---------------------------------
Resolution: Fixed
update the wiki page for the Java DSL and Spring configuration example.
> DataFormat for Google Protocol Buffers
> --------------------------------------
>
> Key: CAMEL-2148
> URL: https://issues.apache.org/activemq/browse/CAMEL-2148
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Martin Gilday
> Assignee: Willem Jiang
> Fix For: 2.2.0
>
> Attachments: camel-protobuf.zip
>
>
> DataFormat for Google Protocol Buffers aka protobuf
> http://code.google.com/apis/protocolbuffers/
> http://code.google.com/p/protobuf/
> The Google project uses 'New BSD License'. Is this a compatible license? Camel Extra seems to just be for GPL style licenses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2148) DataFormat for Google Protocol
Buffers
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56509#action_56509 ]
Willem Jiang commented on CAMEL-2148:
-------------------------------------
Hi Martin,
I found the way to generate the AddressBookProtos myself, so you don't need to regenerate the file.
> DataFormat for Google Protocol Buffers
> --------------------------------------
>
> Key: CAMEL-2148
> URL: https://issues.apache.org/activemq/browse/CAMEL-2148
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Martin Gilday
> Assignee: Willem Jiang
> Fix For: 2.2.0
>
> Attachments: camel-protobuf.zip
>
>
> DataFormat for Google Protocol Buffers aka protobuf
> http://code.google.com/apis/protocolbuffers/
> http://code.google.com/p/protobuf/
> The Google project uses 'New BSD License'. Is this a compatible license? Camel Extra seems to just be for GPL style licenses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2148) DataFormat for Google Protocol
Buffers
Posted by "Martin Gilday (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56500#action_56500 ]
Martin Gilday commented on CAMEL-2148:
--------------------------------------
Willem,
I can run it again this evening.
I asked in the protobuf mailing list but the response was that you need to tell it the type of class to unmarshal too
http://groups.google.com/group/protobuf/browse_frm/thread/74260cf14746b961?tvc=1&q=camel
> DataFormat for Google Protocol Buffers
> --------------------------------------
>
> Key: CAMEL-2148
> URL: https://issues.apache.org/activemq/browse/CAMEL-2148
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Martin Gilday
> Assignee: Willem Jiang
> Fix For: 2.2.0
>
> Attachments: camel-protobuf.zip
>
>
> DataFormat for Google Protocol Buffers aka protobuf
> http://code.google.com/apis/protocolbuffers/
> http://code.google.com/p/protobuf/
> The Google project uses 'New BSD License'. Is this a compatible license? Camel Extra seems to just be for GPL style licenses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2148) DataFormat for Google Protocol
Buffers
Posted by "Martin Gilday (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56523#action_56523 ]
Martin Gilday commented on CAMEL-2148:
--------------------------------------
Thanks Willem for applying this. Is it possible for the DSL to also allow you to pass in the Class as I had it originally, as an overload to the String version? Then we get the option of type checking in the IDE.
> DataFormat for Google Protocol Buffers
> --------------------------------------
>
> Key: CAMEL-2148
> URL: https://issues.apache.org/activemq/browse/CAMEL-2148
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Martin Gilday
> Assignee: Willem Jiang
> Fix For: 2.2.0
>
> Attachments: camel-protobuf.zip
>
>
> DataFormat for Google Protocol Buffers aka protobuf
> http://code.google.com/apis/protocolbuffers/
> http://code.google.com/p/protobuf/
> The Google project uses 'New BSD License'. Is this a compatible license? Camel Extra seems to just be for GPL style licenses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2148) DataFormat for Google Protocol
Buffers
Posted by "Martin Gilday (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56496#action_56496 ]
Martin Gilday commented on CAMEL-2148:
--------------------------------------
Yes I can write the docs for the wiki. Do you plan to add it to the DSL, as that would affect the usage?
> DataFormat for Google Protocol Buffers
> --------------------------------------
>
> Key: CAMEL-2148
> URL: https://issues.apache.org/activemq/browse/CAMEL-2148
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Martin Gilday
> Assignee: Willem Jiang
> Fix For: 2.2.0
>
> Attachments: camel-protobuf.zip
>
>
> DataFormat for Google Protocol Buffers aka protobuf
> http://code.google.com/apis/protocolbuffers/
> http://code.google.com/p/protobuf/
> The Google project uses 'New BSD License'. Is this a compatible license? Camel Extra seems to just be for GPL style licenses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2148) DataFormat for Google Protocol
Buffers
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56510#action_56510 ]
Willem Jiang commented on CAMEL-2148:
-------------------------------------
Committed the patch of Martin with thank, some package refactoring , coding formatting.
I also added the DSL for protobuf, like this
{code}
from("direct:marshal").marshal().protobuf();
from("direct:unmarshal").unmarshal().protobuf("org.apache.camel.dataformat.protobuf.generated.AddressBookProtos$Person").to("mock:reverse");
{code}
http://svn.apache.org/viewvc?rev=892109&view=rev
TODO update the wiki page
> DataFormat for Google Protocol Buffers
> --------------------------------------
>
> Key: CAMEL-2148
> URL: https://issues.apache.org/activemq/browse/CAMEL-2148
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Martin Gilday
> Assignee: Willem Jiang
> Fix For: 2.2.0
>
> Attachments: camel-protobuf.zip
>
>
> DataFormat for Google Protocol Buffers aka protobuf
> http://code.google.com/apis/protocolbuffers/
> http://code.google.com/p/protobuf/
> The Google project uses 'New BSD License'. Is this a compatible license? Camel Extra seems to just be for GPL style licenses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2148) DataFormat for Google Protocol
Buffers
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56527#action_56527 ]
Claus Ibsen commented on CAMEL-2148:
------------------------------------
You can use a (Object instance) method instead? And then do some validation in camel-protobof if that provided instance is an instanceof Message
> DataFormat for Google Protocol Buffers
> --------------------------------------
>
> Key: CAMEL-2148
> URL: https://issues.apache.org/activemq/browse/CAMEL-2148
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Martin Gilday
> Assignee: Willem Jiang
> Fix For: 2.2.0
>
> Attachments: camel-protobuf.zip
>
>
> DataFormat for Google Protocol Buffers aka protobuf
> http://code.google.com/apis/protocolbuffers/
> http://code.google.com/p/protobuf/
> The Google project uses 'New BSD License'. Is this a compatible license? Camel Extra seems to just be for GPL style licenses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2148) DataFormat for Google Protocol
Buffers
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=55221#action_55221 ]
Claus Ibsen commented on CAMEL-2148:
------------------------------------
The licenses is listed here
http://www.apache.org/legal/3party.html
> DataFormat for Google Protocol Buffers
> --------------------------------------
>
> Key: CAMEL-2148
> URL: https://issues.apache.org/activemq/browse/CAMEL-2148
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Martin Gilday
> Attachments: camel-protobuf.zip
>
>
> DataFormat for Google Protocol Buffers aka protobuf
> http://code.google.com/apis/protocolbuffers/
> http://code.google.com/p/protobuf/
> The Google project uses 'New BSD License'. Is this a compatible license? Camel Extra seems to just be for GPL style licenses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2148) DataFormat for Google Protocol
Buffers
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56526#action_56526 ]
Willem Jiang commented on CAMEL-2148:
-------------------------------------
OH, I remember why I don't add the .protobuf(Message defaultInstance) into the DataFormatClause.
It is because I don't want to introduce a new dependency (google protobuf) into camel-core.
> DataFormat for Google Protocol Buffers
> --------------------------------------
>
> Key: CAMEL-2148
> URL: https://issues.apache.org/activemq/browse/CAMEL-2148
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Martin Gilday
> Assignee: Willem Jiang
> Fix For: 2.2.0
>
> Attachments: camel-protobuf.zip
>
>
> DataFormat for Google Protocol Buffers aka protobuf
> http://code.google.com/apis/protocolbuffers/
> http://code.google.com/p/protobuf/
> The Google project uses 'New BSD License'. Is this a compatible license? Camel Extra seems to just be for GPL style licenses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2148) DataFormat for Google Protocol
Buffers
Posted by "Martin Gilday (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56528#action_56528 ]
Martin Gilday commented on CAMEL-2148:
--------------------------------------
That sounds like a good idea
> DataFormat for Google Protocol Buffers
> --------------------------------------
>
> Key: CAMEL-2148
> URL: https://issues.apache.org/activemq/browse/CAMEL-2148
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Martin Gilday
> Assignee: Willem Jiang
> Fix For: 2.2.0
>
> Attachments: camel-protobuf.zip
>
>
> DataFormat for Google Protocol Buffers aka protobuf
> http://code.google.com/apis/protocolbuffers/
> http://code.google.com/p/protobuf/
> The Google project uses 'New BSD License'. Is this a compatible license? Camel Extra seems to just be for GPL style licenses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2148) DataFormat for Google Protocol
Buffers
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56497#action_56497 ]
Claus Ibsen commented on CAMEL-2148:
------------------------------------
Yeah we do have the data formats in the DSL.
Often there are a few options you can configure etc. We can start without the DSL and then add that a bit later.
> DataFormat for Google Protocol Buffers
> --------------------------------------
>
> Key: CAMEL-2148
> URL: https://issues.apache.org/activemq/browse/CAMEL-2148
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Martin Gilday
> Assignee: Willem Jiang
> Fix For: 2.2.0
>
> Attachments: camel-protobuf.zip
>
>
> DataFormat for Google Protocol Buffers aka protobuf
> http://code.google.com/apis/protocolbuffers/
> http://code.google.com/p/protobuf/
> The Google project uses 'New BSD License'. Is this a compatible license? Camel Extra seems to just be for GPL style licenses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CAMEL-2148) DataFormat for Google Protocol
Buffers
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Willem Jiang reassigned CAMEL-2148:
-----------------------------------
Assignee: Willem Jiang
> DataFormat for Google Protocol Buffers
> --------------------------------------
>
> Key: CAMEL-2148
> URL: https://issues.apache.org/activemq/browse/CAMEL-2148
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Martin Gilday
> Assignee: Willem Jiang
> Fix For: 2.2.0
>
> Attachments: camel-protobuf.zip
>
>
> DataFormat for Google Protocol Buffers aka protobuf
> http://code.google.com/apis/protocolbuffers/
> http://code.google.com/p/protobuf/
> The Google project uses 'New BSD License'. Is this a compatible license? Camel Extra seems to just be for GPL style licenses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2148) DataFormat for Google Protocol
Buffers
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56499#action_56499 ]
Willem Jiang commented on CAMEL-2148:
-------------------------------------
Hi Martin,
Can your generate the AddressBookProtos with this package org.apache.camel.dataformat.protobuf.generated again?
As I did some refactoring on the package name and move the generated file there to avoid the CheckStyle checking.
Here is another thing, it look like the ProtobufDataFormat can only unmashal the input stream with a defaultInstance, is there a more generic way to do it without specify the defaultInstance?
> DataFormat for Google Protocol Buffers
> --------------------------------------
>
> Key: CAMEL-2148
> URL: https://issues.apache.org/activemq/browse/CAMEL-2148
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Martin Gilday
> Assignee: Willem Jiang
> Fix For: 2.2.0
>
> Attachments: camel-protobuf.zip
>
>
> DataFormat for Google Protocol Buffers aka protobuf
> http://code.google.com/apis/protocolbuffers/
> http://code.google.com/p/protobuf/
> The Google project uses 'New BSD License'. Is this a compatible license? Camel Extra seems to just be for GPL style licenses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2148) DataFormat for Google Protocol
Buffers
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56491#action_56491 ]
Claus Ibsen commented on CAMEL-2148:
------------------------------------
Martin can you help with providing documentation for this new data format?
> DataFormat for Google Protocol Buffers
> --------------------------------------
>
> Key: CAMEL-2148
> URL: https://issues.apache.org/activemq/browse/CAMEL-2148
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Martin Gilday
> Assignee: Willem Jiang
> Fix For: 2.2.0
>
> Attachments: camel-protobuf.zip
>
>
> DataFormat for Google Protocol Buffers aka protobuf
> http://code.google.com/apis/protocolbuffers/
> http://code.google.com/p/protobuf/
> The Google project uses 'New BSD License'. Is this a compatible license? Camel Extra seems to just be for GPL style licenses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2148) DataFormat for Google Protocol
Buffers
Posted by "Martin Gilday (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56276#action_56276 ]
Martin Gilday commented on CAMEL-2148:
--------------------------------------
The code generator is something you only run once during the design phase of your project to create the message classes (well once per language). I've already run it an placed the generated file under src/test/java.
If you want to run it every time then we could hook it up to the generate-resources Maven phase and invoke it using the Ant plugin. However the code generator is a platform dependant executable. Do you know how this is worked around with the graphviz testing?
Do you think we need to run the code generator at all?
> DataFormat for Google Protocol Buffers
> --------------------------------------
>
> Key: CAMEL-2148
> URL: https://issues.apache.org/activemq/browse/CAMEL-2148
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Martin Gilday
> Fix For: 2.2.0
>
> Attachments: camel-protobuf.zip
>
>
> DataFormat for Google Protocol Buffers aka protobuf
> http://code.google.com/apis/protocolbuffers/
> http://code.google.com/p/protobuf/
> The Google project uses 'New BSD License'. Is this a compatible license? Camel Extra seems to just be for GPL style licenses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2148) DataFormat for Google Protocol
Buffers
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56511#action_56511 ]
Claus Ibsen commented on CAMEL-2148:
------------------------------------
I noticed the pom.xml was set to jar packaging and not bundle.
And I think the code that does ObjectHelper.loadClass should use camelContext.resolveClass instead as its OSGi friendly.
See for example camel-bindy which has such a feature to load classes at runtime that works with OSGi also.
> DataFormat for Google Protocol Buffers
> --------------------------------------
>
> Key: CAMEL-2148
> URL: https://issues.apache.org/activemq/browse/CAMEL-2148
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Martin Gilday
> Assignee: Willem Jiang
> Fix For: 2.2.0
>
> Attachments: camel-protobuf.zip
>
>
> DataFormat for Google Protocol Buffers aka protobuf
> http://code.google.com/apis/protocolbuffers/
> http://code.google.com/p/protobuf/
> The Google project uses 'New BSD License'. Is this a compatible license? Camel Extra seems to just be for GPL style licenses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2148) DataFormat for Google Protocol Buffers
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Claus Ibsen updated CAMEL-2148:
-------------------------------
Fix Version/s: 2.2.0
> DataFormat for Google Protocol Buffers
> --------------------------------------
>
> Key: CAMEL-2148
> URL: https://issues.apache.org/activemq/browse/CAMEL-2148
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Martin Gilday
> Fix For: 2.2.0
>
> Attachments: camel-protobuf.zip
>
>
> DataFormat for Google Protocol Buffers aka protobuf
> http://code.google.com/apis/protocolbuffers/
> http://code.google.com/p/protobuf/
> The Google project uses 'New BSD License'. Is this a compatible license? Camel Extra seems to just be for GPL style licenses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2148) DataFormat for Google Protocol
Buffers
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56524#action_56524 ]
Willem Jiang commented on CAMEL-2148:
-------------------------------------
Hi Martin,
It's not easy to pass a Message instance into an Spring version of DSL, so I introduced the InstanceClass in ProtobufDataFormat.
But I think I can add a Java DSL for setting the Message instance into the ProtobufDataFormat.
> DataFormat for Google Protocol Buffers
> --------------------------------------
>
> Key: CAMEL-2148
> URL: https://issues.apache.org/activemq/browse/CAMEL-2148
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Martin Gilday
> Assignee: Willem Jiang
> Fix For: 2.2.0
>
> Attachments: camel-protobuf.zip
>
>
> DataFormat for Google Protocol Buffers aka protobuf
> http://code.google.com/apis/protocolbuffers/
> http://code.google.com/p/protobuf/
> The Google project uses 'New BSD License'. Is this a compatible license? Camel Extra seems to just be for GPL style licenses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2148) DataFormat for Google Protocol
Buffers
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56512#action_56512 ]
Claus Ibsen commented on CAMEL-2148:
------------------------------------
And there should be a entry added to the features :) as well
I wonder if the google .jar is OSGi bundle already or do we need to provide our own wrapped in SMX repo?
> DataFormat for Google Protocol Buffers
> --------------------------------------
>
> Key: CAMEL-2148
> URL: https://issues.apache.org/activemq/browse/CAMEL-2148
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Martin Gilday
> Assignee: Willem Jiang
> Fix For: 2.2.0
>
> Attachments: camel-protobuf.zip
>
>
> DataFormat for Google Protocol Buffers aka protobuf
> http://code.google.com/apis/protocolbuffers/
> http://code.google.com/p/protobuf/
> The Google project uses 'New BSD License'. Is this a compatible license? Camel Extra seems to just be for GPL style licenses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2148) DataFormat for Google Protocol
Buffers
Posted by "Willem Jiang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56498#action_56498 ]
Willem Jiang commented on CAMEL-2148:
-------------------------------------
Don't worry, I'm doing the DSL part now :)
> DataFormat for Google Protocol Buffers
> --------------------------------------
>
> Key: CAMEL-2148
> URL: https://issues.apache.org/activemq/browse/CAMEL-2148
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Martin Gilday
> Assignee: Willem Jiang
> Fix For: 2.2.0
>
> Attachments: camel-protobuf.zip
>
>
> DataFormat for Google Protocol Buffers aka protobuf
> http://code.google.com/apis/protocolbuffers/
> http://code.google.com/p/protobuf/
> The Google project uses 'New BSD License'. Is this a compatible license? Camel Extra seems to just be for GPL style licenses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CAMEL-2148) DataFormat for Google Protocol Buffers
Posted by "Martin Gilday (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Gilday updated CAMEL-2148:
---------------------------------
Attachment: camel-protobuf.zip
Need to decide which exception should be thrown when unmarshalling a payload which is incomplete/missing required fields.
Need a way to test that exception is thrown correctly. The generated builders by protobuf don't allow creation of incomplete instances.
> DataFormat for Google Protocol Buffers
> --------------------------------------
>
> Key: CAMEL-2148
> URL: https://issues.apache.org/activemq/browse/CAMEL-2148
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Martin Gilday
> Attachments: camel-protobuf.zip
>
>
> DataFormat for Google Protocol Buffers aka protobuf
> http://code.google.com/apis/protocolbuffers/
> http://code.google.com/p/protobuf/
> The Google project uses 'New BSD License'. Is this a compatible license? Camel Extra seems to just be for GPL style licenses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2148) DataFormat for Google Protocol
Buffers
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56301#action_56301 ]
Claus Ibsen commented on CAMEL-2148:
------------------------------------
No I think its fine if the code is generated once and thus not needed to be every time.
> DataFormat for Google Protocol Buffers
> --------------------------------------
>
> Key: CAMEL-2148
> URL: https://issues.apache.org/activemq/browse/CAMEL-2148
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Martin Gilday
> Fix For: 2.2.0
>
> Attachments: camel-protobuf.zip
>
>
> DataFormat for Google Protocol Buffers aka protobuf
> http://code.google.com/apis/protocolbuffers/
> http://code.google.com/p/protobuf/
> The Google project uses 'New BSD License'. Is this a compatible license? Camel Extra seems to just be for GPL style licenses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CAMEL-2148) DataFormat for Google Protocol
Buffers
Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/activemq/browse/CAMEL-2148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=56275#action_56275 ]
Claus Ibsen commented on CAMEL-2148:
------------------------------------
That code generator thing? How does it work with unit testing?
Its preferred if its able to be unit tested completely from a {{mvn clean install}} cmd.
> DataFormat for Google Protocol Buffers
> --------------------------------------
>
> Key: CAMEL-2148
> URL: https://issues.apache.org/activemq/browse/CAMEL-2148
> Project: Apache Camel
> Issue Type: New Feature
> Reporter: Martin Gilday
> Fix For: 2.2.0
>
> Attachments: camel-protobuf.zip
>
>
> DataFormat for Google Protocol Buffers aka protobuf
> http://code.google.com/apis/protocolbuffers/
> http://code.google.com/p/protobuf/
> The Google project uses 'New BSD License'. Is this a compatible license? Camel Extra seems to just be for GPL style licenses.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.