You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/09/01 09:21:14 UTC

[GitHub] [nifi] ChrisSamo632 commented on pull request #5361: NIFI-8749 Remove implicit time zone conversion to GMT

ChrisSamo632 commented on pull request #5361:
URL: https://github.com/apache/nifi/pull/5361#issuecomment-909544892


   These PRs also (helped to) explain some issues I've been having with https://github.com/apache/nifi/pull/4691 for NIFI-7990 too - the implicit GMT conversion was definitely leading to some unexpected behaviours but I wasn't sure whether that was a design/intentional decision within the codebase.
   
   I note that `PutElasticsearchHttpRecord` uses `SimpleDateFormat` instead of `DataTypeUtils.getDateFormat` when converting `DATE` fields, which I've copied into `PutElasticsearchRecord`. With the removal of the implicit GMT conversion I suspect people could move to using the `DataTypeUtils` methods instead in future. That may not be something to add to this PR though, but maybe a separate Jira ticket if it felt useful (think I've read somewhere a desire to replace the use of `SimpleDateFormat`).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org