You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by ni...@apache.org on 2019/06/25 05:36:34 UTC
[kylin] branch 2.6.x updated: KYLIN-4025: Add detail exception in
kylin http response
This is an automated email from the ASF dual-hosted git repository.
nic pushed a commit to branch 2.6.x
in repository https://gitbox.apache.org/repos/asf/kylin.git
The following commit(s) were added to refs/heads/2.6.x by this push:
new dfa6af6 KYLIN-4025: Add detail exception in kylin http response
dfa6af6 is described below
commit dfa6af62b67acbbbd318e910f36ab668316117f8
Author: Liu Shaohui <li...@xiaomi.com>
AuthorDate: Fri May 31 19:16:11 2019 +0800
KYLIN-4025: Add detail exception in kylin http response
---
.../apache/kylin/rest/controller/CubeController.java | 18 +++++++++---------
.../apache/kylin/rest/controller/ModelController.java | 6 +++---
.../kylin/rest/controller/ProjectController.java | 4 ++--
.../kylin/rest/controller/StreamingController.java | 18 +++++++++---------
.../apache/kylin/rest/controller/TableController.java | 12 ++++++------
5 files changed, 29 insertions(+), 29 deletions(-)
diff --git a/server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java b/server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java
index c7626b8..f664e66 100644
--- a/server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java
+++ b/server-base/src/main/java/org/apache/kylin/rest/controller/CubeController.java
@@ -249,7 +249,7 @@ public class CubeController extends BasicController {
cubeService.updateCubeNotifyList(cube, notifyList);
} catch (Exception e) {
logger.error(e.getLocalizedMessage(), e);
- throw new InternalErrorException(e.getLocalizedMessage());
+ throw new InternalErrorException(e.getLocalizedMessage(), e);
}
}
@@ -284,7 +284,7 @@ public class CubeController extends BasicController {
return cubeService.rebuildLookupSnapshot(cube, segmentName, lookupTable);
} catch (IOException e) {
logger.error(e.getLocalizedMessage(), e);
- throw new InternalErrorException(e.getLocalizedMessage());
+ throw new InternalErrorException(e.getLocalizedMessage(), e);
}
}
@@ -306,7 +306,7 @@ public class CubeController extends BasicController {
submitter);
} catch (IOException e) {
logger.error(e.getLocalizedMessage(), e);
- throw new InternalErrorException(e.getLocalizedMessage());
+ throw new InternalErrorException(e.getLocalizedMessage(), e);
}
}
@@ -331,7 +331,7 @@ public class CubeController extends BasicController {
return cubeService.deleteSegment(cube, segmentName);
} catch (Exception e) {
logger.error(e.getLocalizedMessage(), e);
- throw new InternalErrorException(e.getLocalizedMessage());
+ throw new InternalErrorException(e.getLocalizedMessage(), e);
}
}
@@ -424,7 +424,7 @@ public class CubeController extends BasicController {
throw new BadRequestException(e.getLocalizedMessage());
} catch (Exception e) {
logger.error(e.getLocalizedMessage(), e);
- throw new InternalErrorException(e.getLocalizedMessage());
+ throw new InternalErrorException(e.getLocalizedMessage(), e);
}
}
@@ -452,7 +452,7 @@ public class CubeController extends BasicController {
throw new BadRequestException(e.getLocalizedMessage());
} catch (Exception e) {
logger.error(e.getLocalizedMessage(), e);
- throw new InternalErrorException(e.getLocalizedMessage());
+ throw new InternalErrorException(e.getLocalizedMessage(), e);
}
}
@@ -688,7 +688,7 @@ public class CubeController extends BasicController {
throw new ForbiddenException("You don't have right to update this cube.");
} catch (Exception e) {
logger.error("Failed to deal with the request:" + e.getLocalizedMessage(), e);
- throw new InternalErrorException("Failed to deal with the request: " + e.getLocalizedMessage());
+ throw new InternalErrorException("Failed to deal with the request: " + e.getLocalizedMessage(), e);
}
if (desc.isBroken()) {
@@ -857,7 +857,7 @@ public class CubeController extends BasicController {
writer.write(JsonUtil.writeValueAsString(dimensionSetList));
} catch (IOException e) {
logger.error("", e);
- throw new InternalErrorException("Failed to write: " + e.getLocalizedMessage());
+ throw new InternalErrorException("Failed to write: " + e.getLocalizedMessage(), e);
}
}
@@ -1016,4 +1016,4 @@ public class CubeController extends BasicController {
public void setJobService(JobService jobService) {
this.jobService = jobService;
}
-}
\ No newline at end of file
+}
diff --git a/server-base/src/main/java/org/apache/kylin/rest/controller/ModelController.java b/server-base/src/main/java/org/apache/kylin/rest/controller/ModelController.java
index e7de9f4..820d422 100644
--- a/server-base/src/main/java/org/apache/kylin/rest/controller/ModelController.java
+++ b/server-base/src/main/java/org/apache/kylin/rest/controller/ModelController.java
@@ -91,7 +91,7 @@ public class ModelController extends BasicController {
return modelService.getModels(modelName, projectName, limit, offset);
} catch (IOException e) {
logger.error("Failed to deal with the request:" + e.getLocalizedMessage(), e);
- throw new InternalErrorException("Failed to deal with the request: " + e.getLocalizedMessage());
+ throw new InternalErrorException("Failed to deal with the request: " + e.getLocalizedMessage(), e);
}
}
@@ -129,7 +129,7 @@ public class ModelController extends BasicController {
} catch (IOException e) {
// TODO Auto-generated catch block
logger.error("Failed to deal with the request:" + e.getLocalizedMessage(), e);
- throw new InternalErrorException("Failed to deal with the request: " + e.getLocalizedMessage());
+ throw new InternalErrorException("Failed to deal with the request: " + e.getLocalizedMessage(), e);
}
modelRequest.setUuid(modelDesc.getUuid());
@@ -150,7 +150,7 @@ public class ModelController extends BasicController {
throw new ForbiddenException("You don't have right to update this model.");
} catch (Exception e) {
logger.error("Failed to deal with the request:" + e.getLocalizedMessage(), e);
- throw new InternalErrorException("Failed to deal with the request: " + e.getLocalizedMessage());
+ throw new InternalErrorException("Failed to deal with the request: " + e.getLocalizedMessage(), e);
}
if (modelDesc.getError().isEmpty()) {
diff --git a/server-base/src/main/java/org/apache/kylin/rest/controller/ProjectController.java b/server-base/src/main/java/org/apache/kylin/rest/controller/ProjectController.java
index 880c09a..410ff11 100644
--- a/server-base/src/main/java/org/apache/kylin/rest/controller/ProjectController.java
+++ b/server-base/src/main/java/org/apache/kylin/rest/controller/ProjectController.java
@@ -138,7 +138,7 @@ public class ProjectController extends BasicController {
try {
createdProj = projectService.createProject(projectDesc);
} catch (Exception e) {
- throw new InternalErrorException(e.getLocalizedMessage());
+ throw new InternalErrorException(e.getLocalizedMessage(), e);
}
return createdProj;
@@ -169,7 +169,7 @@ public class ProjectController extends BasicController {
}
} catch (Exception e) {
logger.error("Failed to deal with the request.", e);
- throw new InternalErrorException(e.getLocalizedMessage());
+ throw new InternalErrorException(e.getLocalizedMessage(), e);
}
return updatedProj;
diff --git a/server-base/src/main/java/org/apache/kylin/rest/controller/StreamingController.java b/server-base/src/main/java/org/apache/kylin/rest/controller/StreamingController.java
index 0cccca6..36a8a7c 100644
--- a/server-base/src/main/java/org/apache/kylin/rest/controller/StreamingController.java
+++ b/server-base/src/main/java/org/apache/kylin/rest/controller/StreamingController.java
@@ -86,7 +86,7 @@ public class StreamingController extends BasicController {
} catch (IOException e) {
logger.error("Failed to deal with the request:" + e.getLocalizedMessage(), e);
- throw new InternalErrorException("Failed to deal with the request: " + e.getLocalizedMessage());
+ throw new InternalErrorException("Failed to deal with the request: " + e.getLocalizedMessage(), e);
}
}
@@ -101,7 +101,7 @@ public class StreamingController extends BasicController {
return kafkaConfigService.getKafkaConfigs(kafkaConfigName, project, limit, offset);
} catch (IOException e) {
logger.error("Failed to deal with the request:" + e.getLocalizedMessage(), e);
- throw new InternalErrorException("Failed to deal with the request: " + e.getLocalizedMessage());
+ throw new InternalErrorException("Failed to deal with the request: " + e.getLocalizedMessage(), e);
}
}
@@ -149,7 +149,7 @@ public class StreamingController extends BasicController {
saveStreamingSuccess = true;
} catch (IOException e) {
logger.error("Failed to save StreamingConfig:" + e.getLocalizedMessage(), e);
- throw new InternalErrorException("Failed to save StreamingConfig: " + e.getLocalizedMessage());
+ throw new InternalErrorException("Failed to save StreamingConfig: " + e.getLocalizedMessage(), e);
}
try {
kafkaConfig.setUuid(RandomUtil.randomUUID().toString());
@@ -160,10 +160,10 @@ public class StreamingController extends BasicController {
streamingService.dropStreamingConfig(streamingConfig, project);
} catch (IOException e1) {
throw new InternalErrorException(
- "StreamingConfig is created, but failed to create KafkaConfig: " + e.getLocalizedMessage());
+ "StreamingConfig is created, but failed to create KafkaConfig: " + e.getLocalizedMessage(), e);
}
logger.error("Failed to save KafkaConfig:" + e.getLocalizedMessage(), e);
- throw new InternalErrorException("Failed to save KafkaConfig: " + e.getLocalizedMessage());
+ throw new InternalErrorException("Failed to save KafkaConfig: " + e.getLocalizedMessage(), e);
}
} finally {
if (saveKafkaSuccess == false || saveStreamingSuccess == false) {
@@ -176,7 +176,7 @@ public class StreamingController extends BasicController {
} catch (IOException e) {
throw new InternalErrorException(
"Action failed and failed to rollback the created streaming config: "
- + e.getLocalizedMessage());
+ + e.getLocalizedMessage(), e);
}
}
if (saveKafkaSuccess == true) {
@@ -186,7 +186,7 @@ public class StreamingController extends BasicController {
} catch (IOException e) {
throw new InternalErrorException(
"Action failed and failed to rollback the created kafka config: "
- + e.getLocalizedMessage());
+ + e.getLocalizedMessage(), e);
}
}
}
@@ -218,7 +218,7 @@ public class StreamingController extends BasicController {
throw new ForbiddenException("You don't have right to update this StreamingConfig.");
} catch (Exception e) {
logger.error("Failed to deal with the request:" + e.getLocalizedMessage(), e);
- throw new InternalErrorException("Failed to deal with the request: " + e.getLocalizedMessage());
+ throw new InternalErrorException("Failed to deal with the request: " + e.getLocalizedMessage(), e);
}
try {
kafkaConfig = kafkaConfigService.updateKafkaConfig(kafkaConfig, project);
@@ -226,7 +226,7 @@ public class StreamingController extends BasicController {
throw new ForbiddenException("You don't have right to update this KafkaConfig.");
} catch (Exception e) {
logger.error("Failed to deal with the request:" + e.getLocalizedMessage(), e);
- throw new InternalErrorException("Failed to deal with the request: " + e.getLocalizedMessage());
+ throw new InternalErrorException("Failed to deal with the request: " + e.getLocalizedMessage(), e);
}
streamingRequest.setSuccessful(true);
diff --git a/server-base/src/main/java/org/apache/kylin/rest/controller/TableController.java b/server-base/src/main/java/org/apache/kylin/rest/controller/TableController.java
index 4cdc9b6..24cfb1a 100644
--- a/server-base/src/main/java/org/apache/kylin/rest/controller/TableController.java
+++ b/server-base/src/main/java/org/apache/kylin/rest/controller/TableController.java
@@ -81,7 +81,7 @@ public class TableController extends BasicController {
return tableService.getTableDescByProject(project, withExt);
} catch (IOException e) {
logger.error("Failed to get Hive Tables", e);
- throw new InternalErrorException(e.getLocalizedMessage());
+ throw new InternalErrorException(e.getLocalizedMessage(), e);
}
}
@@ -127,7 +127,7 @@ public class TableController extends BasicController {
}
} catch (Throwable e) {
logger.error("Failed to load Hive Table", e);
- throw new InternalErrorException(e.getLocalizedMessage());
+ throw new InternalErrorException(e.getLocalizedMessage(), e);
}
return result;
}
@@ -149,7 +149,7 @@ public class TableController extends BasicController {
}
} catch (Throwable e) {
logger.error("Failed to unload Hive Table", e);
- throw new InternalErrorException(e.getLocalizedMessage());
+ throw new InternalErrorException(e.getLocalizedMessage(), e);
}
result.put("result.unload.success", (String[]) unLoadSuccess.toArray(new String[unLoadSuccess.size()]));
result.put("result.unload.fail", (String[]) unLoadFail.toArray(new String[unLoadFail.size()]));
@@ -176,7 +176,7 @@ public class TableController extends BasicController {
}
} catch (IOException e) {
logger.error("Failed to calculate cardinality", e);
- throw new InternalErrorException(e.getLocalizedMessage());
+ throw new InternalErrorException(e.getLocalizedMessage(), e);
}
return request;
}
@@ -195,7 +195,7 @@ public class TableController extends BasicController {
return tableService.getSourceDbNames(project);
} catch (Throwable e) {
logger.error(e.getLocalizedMessage(), e);
- throw new InternalErrorException(e.getLocalizedMessage());
+ throw new InternalErrorException(e.getLocalizedMessage(), e);
}
}
@@ -213,7 +213,7 @@ public class TableController extends BasicController {
return tableService.getSourceTableNames(project, database);
} catch (Throwable e) {
logger.error(e.getLocalizedMessage(), e);
- throw new InternalErrorException(e.getLocalizedMessage());
+ throw new InternalErrorException(e.getLocalizedMessage(), e);
}
}