[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #646: PHOENIX-5597 No read repair happens when scans filter rows based on a…

[GitBox <gi...@apache.org>]

ChinmaySKulkarni commented on a change in pull request #646: PHOENIX-5597 No read repair happens when scans filter rows based on a…
URL: https://github.com/apache/phoenix/pull/646#discussion_r351960276
 
 

 ##########
 File path: phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java
 ##########
 @@ -355,7 +355,7 @@
     public static final long DEFAULT_TASK_HANDLING_MAX_INTERVAL_MS = 30*60*1000; // 30 min
     public static final long DEFAULT_TASK_HANDLING_INITIAL_DELAY_MS = 10*1000; // 10 sec
 
-    public static final long DEFAULT_GLOBAL_INDEX_ROW_AGE_THRESHOLD_TO_DELETE_MS = 10*60*1000; /* 10 minutes */
+    public static final long DEFAULT_GLOBAL_INDEX_ROW_AGE_THRESHOLD_TO_DELETE_MS = 7*24*60*60*1000; /* 7 days */
 
 Review comment:
   How did we arrive on 7 days as the stopgap before deleting unverified rows? Is it related to the frequency of major compaction or just a general "enough time" to ensure replication lag is covered?
   
   If the former, I would suggest to set this to the value set for the config HConstants.MAJOR_COMPACTION_PERIOD` or default to `HConstants.DEFAULT_MAJOR_COMPACTION_PERIOD`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services