You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by Brent Worden <br...@gmail.com> on 2007/06/07 17:04:32 UTC

[math] deprecation of DistributionFactory

I removed the use of the DistributionFactory and its dependency on
commons-discovery.

The approach I took was to add settable distribution fields where
needed as a replacement for invoking the factory.  These fields always
default to our distribution implementations and can by altered via
constructors as well as setters.

Everything is checked in and critiques are welcome.

Brent Worden

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org


Re: [math] deprecation of DistributionFactory

Posted by Phil Steitz <ph...@gmail.com>.
On 6/7/07, Brent Worden <br...@gmail.com> wrote:
> I removed the use of the DistributionFactory and its dependency on
> commons-discovery.
>
> The approach I took was to add settable distribution fields where
> needed as a replacement for invoking the factory.  These fields always
> default to our distribution implementations and can by altered via
> constructors as well as setters.
>
> Everything is checked in and critiques are welcome.
>

Thanks, Brent!

Looks great, modulo the two diff comments (NPE? and discovery
functionality).  I am fine with the approach and +1 to applying the
same approach to the other abstract factory implementations.  My only
substantive question is whether we should leave the discovery
mechanism working in the deprecated abstract factories.

Phil

---------------------------------------------------------------------
To unsubscribe, e-mail: commons-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: commons-dev-help@jakarta.apache.org