You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by prabhjyotsingh <gi...@git.apache.org> on 2018/03/13 11:26:30 UTC

[GitHub] zeppelin pull request #2862: [ZEPPELIN-3321] isRevisionSupported not working...

GitHub user prabhjyotsingh opened a pull request:

    https://github.com/apache/zeppelin/pull/2862

    [ZEPPELIN-3321] isRevisionSupported not working for importing notebooks.

    ### What is this PR for?
     when importing note of from one zeppelin instance that don't support revision to another zeppelin instance where revision is supported, the imported note still don't support revision.
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### What is the Jira issue?
    * (ZEPPELIN-3321)[https://issues.apache.org/jira/browse/ZEPPELIN-3321]
    
    ### Questions:
    * Does the licenses files need update? N/A
    * Is there breaking changes for older versions? N/A
    * Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3321

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2862.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2862
    
----
commit 18873d3b62a57b07415043aebff1cd991f6d8059
Author: Prabhjyot Singh <pr...@...>
Date:   2018-03-13T11:20:09Z

    ZEPPELIN-3321: fix isRevisionSupported

----


---

[GitHub] zeppelin issue #2862: [ZEPPELIN-3321] isRevisionSupported not working for im...

Posted by r-kamath <gi...@git.apache.org>.

Github user r-kamath commented on the issue:

    https://github.com/apache/zeppelin/pull/2862
  
    @prabhjyotsingh please add a test


---

[GitHub] zeppelin issue #2862: [ZEPPELIN-3321] isRevisionSupported not working for im...

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2862
  
    Thanks for the review will merge this if no more discussion.


---

[GitHub] zeppelin issue #2862: [ZEPPELIN-3321] isRevisionSupported not working for im...

Posted by r-kamath <gi...@git.apache.org>.

Github user r-kamath commented on the issue:

    https://github.com/apache/zeppelin/pull/2862
  
    LGTM


---

[GitHub] zeppelin issue #2862: [ZEPPELIN-3321] isRevisionSupported not working for im...

Posted by zjffdu <gi...@git.apache.org>.

Github user zjffdu commented on the issue:

    https://github.com/apache/zeppelin/pull/2862
  
    LGTM


---

[GitHub] zeppelin issue #2862: [ZEPPELIN-3321] isRevisionSupported not working for im...

Posted by prabhjyotsingh <gi...@git.apache.org>.

Github user prabhjyotsingh commented on the issue:

    https://github.com/apache/zeppelin/pull/2862
  
    @zjffdu, @r-kamath  can you help review this.


---

[GitHub] zeppelin pull request #2862: [ZEPPELIN-3321] isRevisionSupported not working...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2862


---