You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/08/28 01:22:32 UTC

[GitHub] [orc] dongjoon-hyun commented on a change in pull request #885: ORC-974: Remove Text Key from RedBlackTree

dongjoon-hyun commented on a change in pull request #885:
URL: https://github.com/apache/orc/pull/885#discussion_r697784181



##########
File path: java/core/src/java/org/apache/orc/impl/RedBlackTree.java
##########
@@ -147,8 +147,8 @@ private void setRight(int position, int right) {
    * @param greatGrandparent Grandparent's parent
    * @return Does parent also need to be checked and/or fixed?
    */
-  private boolean add(int node, boolean fromLeft, int parent,
-                      int grandparent, int greatGrandparent) {
+    private boolean add(int node, boolean fromLeft, int parent, int grandparent,

Review comment:
       indentation?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org