You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "igreenfield (via GitHub)" <gi...@apache.org> on 2024/01/28 10:10:55 UTC

[PR] [Spark-46891] Allow injecting LogicalPlan Statistics visitor. [spark]

igreenfield opened a new pull request, #44917:
URL: https://github.com/apache/spark/pull/44917

   ### What changes were proposed in this pull request?
   Adding ability to inject LogicalPlan statistics visitor. 
   added a new interface: `LogicalPlanStatisticsVisitor` so the generic will not be in the user interface.
   
   
   ### Why are the changes needed?
   the statistics calc does not cover all use cases so if a user has use-case the is not covered or produces incorrect prediction it can be changed.
   
   
   ### Does this PR introduce _any_ user-facing change?
   it adds new configuration: `spark.sql.cbo.planStats.class` and `spark.sql.planStats.class`
   
   
   ### How was this patch tested?
   with current tests.
   
   
   ### Was this patch authored or co-authored using generative AI tooling?
   No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

Re: [PR] [SPARK-46891][SQL] Allow injecting LogicalPlan Statistics visitor. [spark]

Posted by "igreenfield (via GitHub)" <gi...@apache.org>.
igreenfield commented on PR #44917:
URL: https://github.com/apache/spark/pull/44917#issuecomment-1921029429

   @HyukjinKwon Can you review this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org