You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tapestry.apache.org by "Kevin Lin (JIRA)" <ji...@apache.org> on 2012/09/26 11:44:07 UTC

[jira] [Created] (TAP5-2003) Date Picker broken in IE8 after upgrading to T5.3.5

Kevin Lin created TAP5-2003:
-------------------------------

             Summary: Date Picker broken in IE8 after upgrading to T5.3.5
                 Key: TAP5-2003
                 URL: https://issues.apache.org/jira/browse/TAP5-2003
             Project: Tapestry 5
          Issue Type: Bug
          Components: tapestry-core
    Affects Versions: 5.3.5
            Reporter: Kevin Lin
         Attachments: DatePicker_error.gif

After upgrading to 5.3.5, the date picker widget used by DateField component broke in IE8:
After opening the widget, it won't dismiss when user clicking any dates/buttons on it.

>From the look of the JavaScript error, the error is thrown from prototype.js. And if I downgrade Tapestry 5.3.4, the problem is gone.

I notice a change in T5.3.5, which suggest that the new Prototype library doesn't work with date picker anymore:
[TAP5-1989] - Upgrade bundled Prototype to version 1.7.1

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (TAP5-2003) DatePicker component fails on the client side under IE

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAP5-2003:
---------------------------------------

     Labels: ie javascript  (was: javascript)
    Summary: DatePicker component fails on the client side under IE  (was: Revert bundled version of Prototype from 1.7.1 back down to 1.7)

I've spent some time diagnosing this and I'm unable to reproduce it. I've been using IE9 in IE9 and IE8 compatibility mode and it seems to be working ok.  It may be a page initialization problem rather than a specific Prototype problem (I'm working in the 5.4 branch and had to sort out some problems there that may, or may not, affect 5.3.5).
                
> DatePicker component fails on the client side under IE
> ------------------------------------------------------
>
>                 Key: TAP5-2003
>                 URL: https://issues.apache.org/jira/browse/TAP5-2003
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.5
>            Reporter: Kevin Lin
>              Labels: ie, javascript
>         Attachments: DatePicker_error.gif
>
>
> After upgrading to 5.3.5, the date picker widget used by DateField component broke in IE8:
> After opening the widget, it won't dismiss when user clicking any dates/buttons on it.
> From the look of the JavaScript error, the error is thrown from prototype.js. And if I downgrade Tapestry 5.3.4, the problem is gone.
> I notice a change in T5.3.5, which suggest that the new Prototype library doesn't work with date picker anymore:
> [TAP5-1989] - Upgrade bundled Prototype to version 1.7.1

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TAP5-2003) DatePicker component fails on the client side under IE

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468892#comment-13468892 ] 

Howard M. Lewis Ship commented on TAP5-2003:
--------------------------------------------

prototype.js:

    for (var property in styles) {
      if (property === 'opacity') {
        Element.setOpacity(element, styles[property]);
      } else {
        var value = styles[property];
        if (property === 'float' || property === 'cssFloat') {
          property = Object.isUndefined(elementStyle.styleFloat) ?
           'cssFloat' : 'styleFloat';
        }
        elementStyle[property] = value;  // line 3048
      }
    }
                
> DatePicker component fails on the client side under IE
> ------------------------------------------------------
>
>                 Key: TAP5-2003
>                 URL: https://issues.apache.org/jira/browse/TAP5-2003
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.5
>            Reporter: Kevin Lin
>              Labels: ie, javascript
>         Attachments: DatePicker_error.gif
>
>
> After upgrading to 5.3.5, the date picker widget used by DateField component broke in IE8:
> After opening the widget, it won't dismiss when user clicking any dates/buttons on it.
> From the look of the JavaScript error, the error is thrown from prototype.js. And if I downgrade Tapestry 5.3.4, the problem is gone.
> I notice a change in T5.3.5, which suggest that the new Prototype library doesn't work with date picker anymore:
> [TAP5-1989] - Upgrade bundled Prototype to version 1.7.1

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (TAP5-2003) DatePicker component fails on the client side under IE

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAP5-2003:
---------------------------------------

    Labels: ie javascript not-reproducable  (was: ie javascript)
    
> DatePicker component fails on the client side under IE
> ------------------------------------------------------
>
>                 Key: TAP5-2003
>                 URL: https://issues.apache.org/jira/browse/TAP5-2003
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.5
>            Reporter: Kevin Lin
>              Labels: ie, javascript, not-reproducable
>         Attachments: DatePicker_error.gif
>
>
> After upgrading to 5.3.5, the date picker widget used by DateField component broke in IE8:
> After opening the widget, it won't dismiss when user clicking any dates/buttons on it.
> From the look of the JavaScript error, the error is thrown from prototype.js. And if I downgrade Tapestry 5.3.4, the problem is gone.
> I notice a change in T5.3.5, which suggest that the new Prototype library doesn't work with date picker anymore:
> [TAP5-1989] - Upgrade bundled Prototype to version 1.7.1

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (TAP5-2003) DatePicker component fails on the client side under IE

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAP5-2003:
---------------------------------------

     Labels: ie javascript  (was: javascript)
    Summary: DatePicker component fails on the client side under IE  (was: Revert bundled version of Prototype from 1.7.1 back down to 1.7)

I've spent some time diagnosing this and I'm unable to reproduce it. I've been using IE9 in IE9 and IE8 compatibility mode and it seems to be working ok.  It may be a page initialization problem rather than a specific Prototype problem (I'm working in the 5.4 branch and had to sort out some problems there that may, or may not, affect 5.3.5).
                
> DatePicker component fails on the client side under IE
> ------------------------------------------------------
>
>                 Key: TAP5-2003
>                 URL: https://issues.apache.org/jira/browse/TAP5-2003
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.5
>            Reporter: Kevin Lin
>              Labels: ie, javascript
>         Attachments: DatePicker_error.gif
>
>
> After upgrading to 5.3.5, the date picker widget used by DateField component broke in IE8:
> After opening the widget, it won't dismiss when user clicking any dates/buttons on it.
> From the look of the JavaScript error, the error is thrown from prototype.js. And if I downgrade Tapestry 5.3.4, the problem is gone.
> I notice a change in T5.3.5, which suggest that the new Prototype library doesn't work with date picker anymore:
> [TAP5-1989] - Upgrade bundled Prototype to version 1.7.1

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TAP5-2003) DatePicker component fails on the client side under IE

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468923#comment-13468923 ] 

Howard M. Lewis Ship commented on TAP5-2003:
--------------------------------------------

Justed tested on the 5.3 branch and it works, at least in the T5 testing application; I'm going to have to close this soon unless you can provide an example that demonstrates the failure.
                
> DatePicker component fails on the client side under IE
> ------------------------------------------------------
>
>                 Key: TAP5-2003
>                 URL: https://issues.apache.org/jira/browse/TAP5-2003
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.5
>            Reporter: Kevin Lin
>              Labels: ie, javascript, not-reproducable
>         Attachments: DatePicker_error.gif
>
>
> After upgrading to 5.3.5, the date picker widget used by DateField component broke in IE8:
> After opening the widget, it won't dismiss when user clicking any dates/buttons on it.
> From the look of the JavaScript error, the error is thrown from prototype.js. And if I downgrade Tapestry 5.3.4, the problem is gone.
> I notice a change in T5.3.5, which suggest that the new Prototype library doesn't work with date picker anymore:
> [TAP5-1989] - Upgrade bundled Prototype to version 1.7.1

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TAP5-2003) DatePicker component fails on the client side under IE

Posted by "Bob Harner (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469071#comment-13469071 ] 

Bob Harner commented on TAP5-2003:
----------------------------------

I thought I'd try to reproduce this myself today, and I was successful. Here's what I did, using IE 9 on Windows 7 using IE 8 Compatibility mode:

1) With Tap 5.3.4, went to a page in my app with DatePicker (actually the <t:datefield> component). Buttons worked ok.

2) Switched to Tap 5.3.5, rebuilt/restarted the web app, reloaded the page with F5 (*not* clearing browser cache). Buttons *FAILED* to close calendar. The IE console at that time reported "SCRIPT380: Invalid property value. prototype.js, line 3043 character 9"

3) Reloaded with Control-F5 (updating cache), same behavior.

4) Clicked around a bit on the app, did another Control-F5, tried the calendar, buttons worked okay.

I went back and forth between Tapestry 5.3.3, 5.3.4 and 5.3.5 several times and was *almost* always able to get the problem to appear the first time I tried 5.3.5 without clearing the browser cache, and then clearing the cache *almost* always fixed the problem eventually.

My gut feeling is that the problem is caused by old JavaScript in the browser left over from a prior run of 5.3.4. But there's enough flakiness in this component and in the bug's behavior that it's hard to be certain.
                
> DatePicker component fails on the client side under IE
> ------------------------------------------------------
>
>                 Key: TAP5-2003
>                 URL: https://issues.apache.org/jira/browse/TAP5-2003
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.5
>            Reporter: Kevin Lin
>              Labels: ie, javascript, not-reproducable
>         Attachments: DatePicker_error.gif
>
>
> After upgrading to 5.3.5, the date picker widget used by DateField component broke in IE8:
> After opening the widget, it won't dismiss when user clicking any dates/buttons on it.
> From the look of the JavaScript error, the error is thrown from prototype.js. And if I downgrade Tapestry 5.3.4, the problem is gone.
> I notice a change in T5.3.5, which suggest that the new Prototype library doesn't work with date picker anymore:
> [TAP5-1989] - Upgrade bundled Prototype to version 1.7.1

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (TAP5-2003) DatePicker component fails on the client side under IE

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAP5-2003:
---------------------------------------

    Labels: ie javascript not-reproducable  (was: ie javascript)
    
> DatePicker component fails on the client side under IE
> ------------------------------------------------------
>
>                 Key: TAP5-2003
>                 URL: https://issues.apache.org/jira/browse/TAP5-2003
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.5
>            Reporter: Kevin Lin
>              Labels: ie, javascript, not-reproducable
>         Attachments: DatePicker_error.gif
>
>
> After upgrading to 5.3.5, the date picker widget used by DateField component broke in IE8:
> After opening the widget, it won't dismiss when user clicking any dates/buttons on it.
> From the look of the JavaScript error, the error is thrown from prototype.js. And if I downgrade Tapestry 5.3.4, the problem is gone.
> I notice a change in T5.3.5, which suggest that the new Prototype library doesn't work with date picker anymore:
> [TAP5-1989] - Upgrade bundled Prototype to version 1.7.1

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Comment Edited] (TAP5-2003) DatePicker component fails on the client side under IE

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468892#comment-13468892 ] 

Howard M. Lewis Ship edited comment on TAP5-2003 at 10/4/12 8:58 AM:
---------------------------------------------------------------------

prototype.js:

    for (var property in styles) {
      if (property === 'opacity') {
        Element.setOpacity(element, styles[property]);
      } else {
        var value = styles[property];
        if (property === 'float' || property === 'cssFloat') {
          property = Object.isUndefined(elementStyle.styleFloat) ?
           'cssFloat' : 'styleFloat';
        }
        elementStyle[property] = value;  // line 3043
      }
    }
                
      was (Author: hlship):
    prototype.js:

    for (var property in styles) {
      if (property === 'opacity') {
        Element.setOpacity(element, styles[property]);
      } else {
        var value = styles[property];
        if (property === 'float' || property === 'cssFloat') {
          property = Object.isUndefined(elementStyle.styleFloat) ?
           'cssFloat' : 'styleFloat';
        }
        elementStyle[property] = value;  // line 3048
      }
    }
                  
> DatePicker component fails on the client side under IE
> ------------------------------------------------------
>
>                 Key: TAP5-2003
>                 URL: https://issues.apache.org/jira/browse/TAP5-2003
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.5
>            Reporter: Kevin Lin
>              Labels: ie, javascript
>         Attachments: DatePicker_error.gif
>
>
> After upgrading to 5.3.5, the date picker widget used by DateField component broke in IE8:
> After opening the widget, it won't dismiss when user clicking any dates/buttons on it.
> From the look of the JavaScript error, the error is thrown from prototype.js. And if I downgrade Tapestry 5.3.4, the problem is gone.
> I notice a change in T5.3.5, which suggest that the new Prototype library doesn't work with date picker anymore:
> [TAP5-1989] - Upgrade bundled Prototype to version 1.7.1

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TAP5-2003) DatePicker component fails on the client side under IE

Posted by "Bob Harner (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13469071#comment-13469071 ] 

Bob Harner commented on TAP5-2003:
----------------------------------

I thought I'd try to reproduce this myself today, and I was successful. Here's what I did, using IE 9 on Windows 7 using IE 8 Compatibility mode:

1) With Tap 5.3.4, went to a page in my app with DatePicker (actually the <t:datefield> component). Buttons worked ok.

2) Switched to Tap 5.3.5, rebuilt/restarted the web app, reloaded the page with F5 (*not* clearing browser cache). Buttons *FAILED* to close calendar. The IE console at that time reported "SCRIPT380: Invalid property value. prototype.js, line 3043 character 9"

3) Reloaded with Control-F5 (updating cache), same behavior.

4) Clicked around a bit on the app, did another Control-F5, tried the calendar, buttons worked okay.

I went back and forth between Tapestry 5.3.3, 5.3.4 and 5.3.5 several times and was *almost* always able to get the problem to appear the first time I tried 5.3.5 without clearing the browser cache, and then clearing the cache *almost* always fixed the problem eventually.

My gut feeling is that the problem is caused by old JavaScript in the browser left over from a prior run of 5.3.4. But there's enough flakiness in this component and in the bug's behavior that it's hard to be certain.
                
> DatePicker component fails on the client side under IE
> ------------------------------------------------------
>
>                 Key: TAP5-2003
>                 URL: https://issues.apache.org/jira/browse/TAP5-2003
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.5
>            Reporter: Kevin Lin
>              Labels: ie, javascript, not-reproducable
>         Attachments: DatePicker_error.gif
>
>
> After upgrading to 5.3.5, the date picker widget used by DateField component broke in IE8:
> After opening the widget, it won't dismiss when user clicking any dates/buttons on it.
> From the look of the JavaScript error, the error is thrown from prototype.js. And if I downgrade Tapestry 5.3.4, the problem is gone.
> I notice a change in T5.3.5, which suggest that the new Prototype library doesn't work with date picker anymore:
> [TAP5-1989] - Upgrade bundled Prototype to version 1.7.1

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TAP5-2003) DatePicker component fails on the client side under IE

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468923#comment-13468923 ] 

Howard M. Lewis Ship commented on TAP5-2003:
--------------------------------------------

Justed tested on the 5.3 branch and it works, at least in the T5 testing application; I'm going to have to close this soon unless you can provide an example that demonstrates the failure.
                
> DatePicker component fails on the client side under IE
> ------------------------------------------------------
>
>                 Key: TAP5-2003
>                 URL: https://issues.apache.org/jira/browse/TAP5-2003
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.5
>            Reporter: Kevin Lin
>              Labels: ie, javascript, not-reproducable
>         Attachments: DatePicker_error.gif
>
>
> After upgrading to 5.3.5, the date picker widget used by DateField component broke in IE8:
> After opening the widget, it won't dismiss when user clicking any dates/buttons on it.
> From the look of the JavaScript error, the error is thrown from prototype.js. And if I downgrade Tapestry 5.3.4, the problem is gone.
> I notice a change in T5.3.5, which suggest that the new Prototype library doesn't work with date picker anymore:
> [TAP5-1989] - Upgrade bundled Prototype to version 1.7.1

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (TAP5-2003) Revert bundled version of Prototype from 1.7.1 back down to 1.7

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAP5-2003:
---------------------------------------

    Summary: Revert bundled version of Prototype from 1.7.1 back down to 1.7  (was: Date Picker broken in IE8 after upgrading to T5.3.5)
    
> Revert bundled version of Prototype from 1.7.1 back down to 1.7
> ---------------------------------------------------------------
>
>                 Key: TAP5-2003
>                 URL: https://issues.apache.org/jira/browse/TAP5-2003
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.5
>            Reporter: Kevin Lin
>              Labels: javascript
>         Attachments: DatePicker_error.gif
>
>
> After upgrading to 5.3.5, the date picker widget used by DateField component broke in IE8:
> After opening the widget, it won't dismiss when user clicking any dates/buttons on it.
> From the look of the JavaScript error, the error is thrown from prototype.js. And if I downgrade Tapestry 5.3.4, the problem is gone.
> I notice a change in T5.3.5, which suggest that the new Prototype library doesn't work with date picker anymore:
> [TAP5-1989] - Upgrade bundled Prototype to version 1.7.1

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Commented] (TAP5-2003) DatePicker component fails on the client side under IE

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468892#comment-13468892 ] 

Howard M. Lewis Ship commented on TAP5-2003:
--------------------------------------------

prototype.js:

    for (var property in styles) {
      if (property === 'opacity') {
        Element.setOpacity(element, styles[property]);
      } else {
        var value = styles[property];
        if (property === 'float' || property === 'cssFloat') {
          property = Object.isUndefined(elementStyle.styleFloat) ?
           'cssFloat' : 'styleFloat';
        }
        elementStyle[property] = value;  // line 3048
      }
    }
                
> DatePicker component fails on the client side under IE
> ------------------------------------------------------
>
>                 Key: TAP5-2003
>                 URL: https://issues.apache.org/jira/browse/TAP5-2003
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.5
>            Reporter: Kevin Lin
>              Labels: ie, javascript
>         Attachments: DatePicker_error.gif
>
>
> After upgrading to 5.3.5, the date picker widget used by DateField component broke in IE8:
> After opening the widget, it won't dismiss when user clicking any dates/buttons on it.
> From the look of the JavaScript error, the error is thrown from prototype.js. And if I downgrade Tapestry 5.3.4, the problem is gone.
> I notice a change in T5.3.5, which suggest that the new Prototype library doesn't work with date picker anymore:
> [TAP5-1989] - Upgrade bundled Prototype to version 1.7.1

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Comment Edited] (TAP5-2003) DatePicker component fails on the client side under IE

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/TAP5-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13468892#comment-13468892 ] 

Howard M. Lewis Ship edited comment on TAP5-2003 at 10/4/12 8:58 AM:
---------------------------------------------------------------------

prototype.js:

    for (var property in styles) {
      if (property === 'opacity') {
        Element.setOpacity(element, styles[property]);
      } else {
        var value = styles[property];
        if (property === 'float' || property === 'cssFloat') {
          property = Object.isUndefined(elementStyle.styleFloat) ?
           'cssFloat' : 'styleFloat';
        }
        elementStyle[property] = value;  // line 3043
      }
    }
                
      was (Author: hlship):
    prototype.js:

    for (var property in styles) {
      if (property === 'opacity') {
        Element.setOpacity(element, styles[property]);
      } else {
        var value = styles[property];
        if (property === 'float' || property === 'cssFloat') {
          property = Object.isUndefined(elementStyle.styleFloat) ?
           'cssFloat' : 'styleFloat';
        }
        elementStyle[property] = value;  // line 3048
      }
    }
                  
> DatePicker component fails on the client side under IE
> ------------------------------------------------------
>
>                 Key: TAP5-2003
>                 URL: https://issues.apache.org/jira/browse/TAP5-2003
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.5
>            Reporter: Kevin Lin
>              Labels: ie, javascript
>         Attachments: DatePicker_error.gif
>
>
> After upgrading to 5.3.5, the date picker widget used by DateField component broke in IE8:
> After opening the widget, it won't dismiss when user clicking any dates/buttons on it.
> From the look of the JavaScript error, the error is thrown from prototype.js. And if I downgrade Tapestry 5.3.4, the problem is gone.
> I notice a change in T5.3.5, which suggest that the new Prototype library doesn't work with date picker anymore:
> [TAP5-1989] - Upgrade bundled Prototype to version 1.7.1

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (TAP5-2003) Date Picker broken in IE8 after upgrading to T5.3.5

Posted by "Kevin Lin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Lin updated TAP5-2003:
----------------------------

    Attachment: DatePicker_error.gif
    
> Date Picker broken in IE8 after upgrading to T5.3.5
> ---------------------------------------------------
>
>                 Key: TAP5-2003
>                 URL: https://issues.apache.org/jira/browse/TAP5-2003
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.5
>            Reporter: Kevin Lin
>              Labels: javascript
>         Attachments: DatePicker_error.gif
>
>
> After upgrading to 5.3.5, the date picker widget used by DateField component broke in IE8:
> After opening the widget, it won't dismiss when user clicking any dates/buttons on it.
> From the look of the JavaScript error, the error is thrown from prototype.js. And if I downgrade Tapestry 5.3.4, the problem is gone.
> I notice a change in T5.3.5, which suggest that the new Prototype library doesn't work with date picker anymore:
> [TAP5-1989] - Upgrade bundled Prototype to version 1.7.1

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (TAP5-2003) Revert bundled version of Prototype from 1.7.1 back down to 1.7

Posted by "Howard M. Lewis Ship (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Howard M. Lewis Ship updated TAP5-2003:
---------------------------------------

    Summary: Revert bundled version of Prototype from 1.7.1 back down to 1.7  (was: Date Picker broken in IE8 after upgrading to T5.3.5)
    
> Revert bundled version of Prototype from 1.7.1 back down to 1.7
> ---------------------------------------------------------------
>
>                 Key: TAP5-2003
>                 URL: https://issues.apache.org/jira/browse/TAP5-2003
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.5
>            Reporter: Kevin Lin
>              Labels: javascript
>         Attachments: DatePicker_error.gif
>
>
> After upgrading to 5.3.5, the date picker widget used by DateField component broke in IE8:
> After opening the widget, it won't dismiss when user clicking any dates/buttons on it.
> From the look of the JavaScript error, the error is thrown from prototype.js. And if I downgrade Tapestry 5.3.4, the problem is gone.
> I notice a change in T5.3.5, which suggest that the new Prototype library doesn't work with date picker anymore:
> [TAP5-1989] - Upgrade bundled Prototype to version 1.7.1

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Updated] (TAP5-2003) Date Picker broken in IE8 after upgrading to T5.3.5

Posted by "Kevin Lin (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/TAP5-2003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Lin updated TAP5-2003:
----------------------------

    Attachment: DatePicker_error.gif
    
> Date Picker broken in IE8 after upgrading to T5.3.5
> ---------------------------------------------------
>
>                 Key: TAP5-2003
>                 URL: https://issues.apache.org/jira/browse/TAP5-2003
>             Project: Tapestry 5
>          Issue Type: Bug
>          Components: tapestry-core
>    Affects Versions: 5.3.5
>            Reporter: Kevin Lin
>              Labels: javascript
>         Attachments: DatePicker_error.gif
>
>
> After upgrading to 5.3.5, the date picker widget used by DateField component broke in IE8:
> After opening the widget, it won't dismiss when user clicking any dates/buttons on it.
> From the look of the JavaScript error, the error is thrown from prototype.js. And if I downgrade Tapestry 5.3.4, the problem is gone.
> I notice a change in T5.3.5, which suggest that the new Prototype library doesn't work with date picker anymore:
> [TAP5-1989] - Upgrade bundled Prototype to version 1.7.1

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira