You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2018/02/02 12:54:27 UTC
[GitHub] ctubbsii commented on a change in pull request #373: ACCUMULO-4709 sanity check in Mutation
ctubbsii commented on a change in pull request #373: ACCUMULO-4709 sanity check in Mutation
URL: https://github.com/apache/accumulo/pull/373#discussion_r165634420
##########
File path: core/src/main/java/org/apache/accumulo/core/data/Mutation.java
##########
@@ -66,18 +68,44 @@
*/
static final int VALUE_SIZE_COPY_CUTOFF = 1 << 15;
+ /**
+ * Maximum size of a mutation (2GB).
+ */
+ static final long MAX_MUTATION_SIZE = 2l * (1 << 30);
Review comment:
Minor nit: prefer uppercase L for long literals. It's easier to read, especially for programmers with poor eyesight.
Also, `1L << 31` is simpler.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services