You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@amoro.apache.org by "turboFei (via GitHub)" <gi...@apache.org> on 2025/11/30 21:44:08 UTC
[PR] [AMORO-3981][FOLLOWUP] Refine duration type parse and to string [amoro]
turboFei opened a new pull request, #3987:
URL: https://github.com/apache/amoro/pull/3987
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://amoro.apache.org/how-to-contribute/
2. If the PR is related to an issue in https://github.com/apache/amoro/issues, add '[AMORO-XXXX]' in your PR title, e.g., '[AMORO-XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][AMORO-XXXX] Your PR title ...'.
-->
## Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about its use case.
2. If you fix a bug, you can clarify why it is a bug.
3. Use Fix/Resolve/Close #{ISSUE_NUMBER} to link this PR to its related issue
-->
Close #xxx.
## Brief change log
<!--
Clearly describe the changes made in modules, classes, methods, etc.
-->
-
## How was this patch tested?
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] Run test locally before making a pull request
## Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3981][FOLLOWUP] Refine duration type parse and convert to string [amoro]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #3987:
URL: https://github.com/apache/amoro/pull/3987#issuecomment-3593582287
I will regenerate the docs after #3982 got merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3981][FOLLOWUP] Support duration type ConfigOption in ISO-8601 format [amoro]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #3987:
URL: https://github.com/apache/amoro/pull/3987#issuecomment-3619513466
## [Codecov](https://app.codecov.io/gh/apache/amoro/pull/3987?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:x: Patch coverage is `66.66667%` with `1 line` in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 22.47%. Comparing base ([`cbdc517`](https://app.codecov.io/gh/apache/amoro/commit/cbdc5176b760b2ab46daa5051f29b72f1fee7175?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`877bcb9`](https://app.codecov.io/gh/apache/amoro/commit/877bcb9a71f12173a6ee6961b4e3a61091c76140?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 6 commits behind head on master.
| [Files with missing lines](https://app.codecov.io/gh/apache/amoro/pull/3987?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...in/java/org/apache/amoro/config/ConfigHelpers.java](https://app.codecov.io/gh/apache/amoro/pull/3987?src=pr&el=tree&filepath=amoro-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Famoro%2Fconfig%2FConfigHelpers.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-YW1vcm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9hbW9yby9jb25maWcvQ29uZmlnSGVscGVycy5qYXZh) | 66.66% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/amoro/pull/3987?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #3987 +/- ##
============================================
+ Coverage 22.12% 22.47% +0.35%
- Complexity 2461 2506 +45
============================================
Files 445 446 +1
Lines 40897 40953 +56
Branches 5767 5767
============================================
+ Hits 9050 9206 +156
+ Misses 31089 30964 -125
- Partials 758 783 +25
```
| [Flag](https://app.codecov.io/gh/apache/amoro/pull/3987/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [trino](https://app.codecov.io/gh/apache/amoro/pull/3987/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `22.47% <66.66%> (+0.35%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/amoro/pull/3987?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3981][FOLLOWUP] Refine the duration format to string [amoro]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #3987:
URL: https://github.com/apache/amoro/pull/3987#discussion_r2594644398
##########
docs/configuration/ams-config.md:
##########
@@ -52,10 +52,10 @@ table td:last-child, table th:last-child { width: 40%; word-break: break-all; }
| clean-dangling-delete-files.enabled | true | Enable dangling delete files cleaning. |
| clean-dangling-delete-files.thread-count | 10 | The number of threads used for dangling delete files cleaning. |
| clean-orphan-files.enabled | true | Enable orphan files cleaning. |
-| clean-orphan-files.interval | 86400000 ms | Interval for cleaning orphan files. |
+| clean-orphan-files.interval | 1 d | Interval for cleaning orphan files. |
Review Comment:
without
```
// Use the largest unit if all divide evenly
.orElse(orderedUnits.get(orderedUnits.size() - 1));
```
It shows `86400000 ms` instead of `1d`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3981][FOLLOWUP] Support duration type ConfigOption in ISO-8601 format [amoro]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #3987:
URL: https://github.com/apache/amoro/pull/3987#issuecomment-3619507895
cc @huyuanfeng2018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3981][FOLLOWUP] Support duration type ConfigOption in ISO-8601 format [amoro]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei closed pull request #3987: [AMORO-3981][FOLLOWUP] Support duration type ConfigOption in ISO-8601 format
URL: https://github.com/apache/amoro/pull/3987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3981][FOLLOWUP] Refine the duration format to string [amoro]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #3987:
URL: https://github.com/apache/amoro/pull/3987#discussion_r2594644398
##########
docs/configuration/ams-config.md:
##########
@@ -52,10 +52,10 @@ table td:last-child, table th:last-child { width: 40%; word-break: break-all; }
| clean-dangling-delete-files.enabled | true | Enable dangling delete files cleaning. |
| clean-dangling-delete-files.thread-count | 10 | The number of threads used for dangling delete files cleaning. |
| clean-orphan-files.enabled | true | Enable orphan files cleaning. |
-| clean-orphan-files.interval | 86400000 ms | Interval for cleaning orphan files. |
+| clean-orphan-files.interval | 1 d | Interval for cleaning orphan files. |
Review Comment:
```
// Use the largest unit if all divide evenly
.orElse(orderedUnits.get(orderedUnits.size() - 1));
```
It is used to show `1 d` instead of `86400000 ms`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3981][FOLLOWUP] Support duration type ConfigOption in ISO-8601 format [amoro]
Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #3987:
URL: https://github.com/apache/amoro/pull/3987#issuecomment-3619710625
> I think need to refer to it here: `org.apache.amoro.config.ConfigHelpers#TimeUtils`
Thanks for the suggestion, I have updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [AMORO-3981][FOLLOWUP] Refine the duration to string format [amoro]
Posted by "huyuanfeng2018 (via GitHub)" <gi...@apache.org>.
huyuanfeng2018 merged PR #3987:
URL: https://github.com/apache/amoro/pull/3987
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@amoro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org