You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/02/28 14:31:09 UTC

[GitHub] [arrow] rok commented on a change in pull request #12515: ARROW-15680: [C++] Temporal floor/ceil/round should accept week_starts_monday when rounding to multiple of week

rok commented on a change in pull request #12515:
URL: https://github.com/apache/arrow/pull/12515#discussion_r815939936



##########
File path: cpp/src/arrow/compute/kernels/scalar_temporal_unary.cc
##########
@@ -725,6 +725,27 @@ const Duration FloorTimePoint(const int64_t arg, const int64_t multiple,
   }
 }
 
+template <typename Duration, typename Unit, typename Localizer>

Review comment:
       Good point! I originally wanted to use `Ceil/Floor/RoundTimePoint` but then changed the design and forgot this there. Will fix.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org