You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2026/09/30 08:18:56 UTC
[PR] [MSE] Stream ordered leaf selection across sorted segments [pinot]
xiangfu0 opened a new pull request, #19712:
URL: https://github.com/apache/pinot/pull/19712
Port Rohit's latest #19120 commits onto the shared ordering stack, preserving author history and the default OFF behavior; the server streams ordered segment runs and merges them in bounded blocks.
Try `SET useMultistageEngine=true; SET streamingSortedMailboxReceive=true; SET sortedSelectionMergeMode='AUTO'; SELECT key FROM myTable_OFFLINE ORDER BY key LIMIT 10;` on segments sorted by key; `OFF` restores the existing server path.
158 focused source/merge tests and scoped style/license checks pass. Parent: https://github.com/apache/pinot/pull/19711; child: the sorted-join follow-up. Fresh cluster benchmarks remain pending; #19120 is left open for author coordination.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [MSE] Stream ordered leaf selection across sorted segments [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on PR #19712:
URL: https://github.com/apache/pinot/pull/19712#issuecomment-6015758824
CI follow-up at `83040faa` adds six exact stacked-base `pull_request` branch filters (+6/-0). Feature code/tests and existing master/push, path, permission and job rules are preserved.
All 14 current-head checks passed: unit/integration, compatibility, quickstart, Java 11 client, linter and Trivy ([checks](https://github.com/apache/pinot/pull/19712/checks?sha=83040faaa2a29513860632e081dba572c42dc472)). Maintainer review remains pending.
The first attempt hit an unchanged ingestion-test Mockito concurrency error; one failed-job-only rerun passed on the same head ([original attempt](https://github.com/apache/pinot/actions/runs/37449003971/attempts/1)).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] [MSE] Stream ordered leaf selection across sorted segments [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19712:
URL: https://github.com/apache/pinot/pull/19712#issuecomment-6015008438
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/19712?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:warning: Please [upload](https://docs.codecov.com/docs/codecov-uploader) report for BASE (`xiangfu0/codex1/sorted-exchange-ordering@755721f`). [Learn more](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#section-missing-base-commit) about missing BASE report.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## xiangfu0/codex1/sorted-exchange-ordering #19712 +/- ##
============================================================================
Coverage ? 100.00%
Complexity ? 6
============================================================================
Files ? 3
Lines ? 6
Branches ? 0
============================================================================
Hits ? 6
Misses ? 0
Partials ? 0
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/19712/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [integration](https://app.codecov.io/gh/apache/pinot/pull/19712/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (?)` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/19712/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (?)` | |
| [java-25](https://app.codecov.io/gh/apache/pinot/pull/19712/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (?)` | |
| [lane-a](https://app.codecov.io/gh/apache/pinot/pull/19712/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (?)` | |
| [lane-b](https://app.codecov.io/gh/apache/pinot/pull/19712/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (?)` | |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/19712/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/pinot/pull/19712?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org