You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by md...@apache.org on 2016/12/14 13:19:37 UTC

svn commit: r1774220 - /jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentNodeState.java

Author: mduerig
Date: Wed Dec 14 13:19:37 2016
New Revision: 1774220

URL: http://svn.apache.org/viewvc?rev=1774220&view=rev
Log:
OAK-5293: Static code analysis and code cleanup
Replace if with switch

Modified:
    jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentNodeState.java

Modified: jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentNodeState.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentNodeState.java?rev=1774220&r1=1774219&r2=1774220&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentNodeState.java (original)
+++ jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentNodeState.java Wed Dec 14 13:19:37 2016
@@ -172,12 +172,13 @@ public class SegmentNodeState extends Re
     public boolean hasProperty(@Nonnull String name) {
         checkNotNull(name);
         Template template = getTemplate();
-        if (JCR_PRIMARYTYPE.equals(name)) {
-            return template.getPrimaryType() != null;
-        } else if (JCR_MIXINTYPES.equals(name)) {
-            return template.getMixinTypes() != null;
-        } else {
-            return template.getPropertyTemplate(name) != null;
+        switch (name) {
+            case JCR_PRIMARYTYPE:
+                return template.getPrimaryType() != null;
+            case JCR_MIXINTYPES:
+                return template.getMixinTypes() != null;
+            default:
+                return template.getPropertyTemplate(name) != null;
         }
     }