[GitHub] [skywalking-python] tom-pytel opened a new pull request #141: NoopSpan on queue full, propagation downstream

[GitBox <gi...@apache.org>]

tom-pytel opened a new pull request #141:
URL: https://github.com/apache/skywalking-python/pull/141


   This has two things similar to the Node agent PR 50, it has:
   * Spans which are ignored due to suffix or endpoint name pattern match will propagate their ignored status downstream via dummy span and sending an empty "sw8" header. If such an empty header is received then a dummy context and span is created instead of a new actively traced segment. This is only a behavior change for this node agent and is compatible with other language agents, they will just act as they have always done.
   * The method of limiting the number of segments which are recorded has been changed from post-record check to pre-record check to avoid unnecessary instrumentation if the number of segments already exceeds the threshold and the data would be thrown away anyway. This also allows propagation of ignored status of segment downstream via mechanism described above to avoid broken "VNode" segments in trace view.
   
   And the minor little detail in `sw_urllib_request`, the change from:
   ```py
   [fullurl.add_header(item.key, item.val) for item in carrier]
   ```
   To:
   ```py
   for item in carrier:
       fullurl.add_header(item.key, item.val)
   ```
   The first form is not ideal since it actually creates the intermediate list object from the comprehension unnecessarily.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-python] kezhenxu94 merged pull request #141: NoopSpan on queue full, propagation downstream

[GitBox <gi...@apache.org>]

kezhenxu94 merged pull request #141:
URL: https://github.com/apache/skywalking-python/pull/141


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org