You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/05/20 03:02:21 UTC
[GitHub] [rocketmq-client-go] Git-Yang opened a new pull request #665: [ISSUE #662] Fix the usage bug of namespace
Git-Yang opened a new pull request #665:
URL: https://github.com/apache/rocketmq-client-go/pull/665
## What is the purpose of the change
- 批量消息Namespace使用错误，需要对所有消息topic添加Namespace
## Brief changelog
- sendSync / sendAsync / sendOneWay 三个接口发送消息时，遍历所有msg，对topic添加Namespace
## Verifying this change
By unit test
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when a cross-module dependency exists.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] wenfengwang merged pull request #665: [ISSUE #662] Fix the usage bug of namespace
Posted by GitBox <gi...@apache.org>.
wenfengwang merged pull request #665:
URL: https://github.com/apache/rocketmq-client-go/pull/665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] codecov-commenter edited a comment on pull request #665: [ISSUE #662] Fix the usage bug of namespace
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #665:
URL: https://github.com/apache/rocketmq-client-go/pull/665#issuecomment-844651601
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/665?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#665](https://codecov.io/gh/apache/rocketmq-client-go/pull/665?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3eb9052) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/dfa26d159f9f47cf38c8788dc3ae9443bad61e0d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dfa26d1) will **increase** coverage by `0.15%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/rocketmq-client-go/pull/665?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #665 +/- ##
==========================================
+ Coverage 24.36% 24.51% +0.15%
==========================================
Files 48 48
Lines 5204 5204
==========================================
+ Hits 1268 1276 +8
+ Misses 3726 3721 -5
+ Partials 210 207 -3
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/665?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [producer/producer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/665/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvZHVjZXIvcHJvZHVjZXIuZ28=) | `28.12% <100.00%> (+1.87%)` | :arrow_up: |
| [producer/option.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/665/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvZHVjZXIvb3B0aW9uLmdv) | `42.22% <0.00%> (+4.44%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/665?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/665?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dfa26d1...3eb9052](https://codecov.io/gh/apache/rocketmq-client-go/pull/665?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] codecov-commenter commented on pull request #665: [ISSUE #662] Fix the usage bug of namespace
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #665:
URL: https://github.com/apache/rocketmq-client-go/pull/665#issuecomment-844651601
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/665?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#665](https://codecov.io/gh/apache/rocketmq-client-go/pull/665?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4f1c53c) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/dfa26d159f9f47cf38c8788dc3ae9443bad61e0d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dfa26d1) will **increase** coverage by `0.17%`.
> The diff coverage is `88.88%`.
[](https://codecov.io/gh/apache/rocketmq-client-go/pull/665?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #665 +/- ##
==========================================
+ Coverage 24.36% 24.54% +0.17%
==========================================
Files 48 48
Lines 5204 5207 +3
==========================================
+ Hits 1268 1278 +10
+ Misses 3726 3722 -4
+ Partials 210 207 -3
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/665?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [producer/producer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/665/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvZHVjZXIvcHJvZHVjZXIuZ28=) | `28.48% <88.88%> (+2.23%)` | :arrow_up: |
| [producer/option.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/665/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvZHVjZXIvb3B0aW9uLmdv) | `42.22% <0.00%> (+4.44%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/665?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/665?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dfa26d1...4f1c53c](https://codecov.io/gh/apache/rocketmq-client-go/pull/665?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-client-go] codecov-commenter edited a comment on pull request #665: [ISSUE #662] Fix the usage bug of namespace
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #665:
URL: https://github.com/apache/rocketmq-client-go/pull/665#issuecomment-844651601
# [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/665?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#665](https://codecov.io/gh/apache/rocketmq-client-go/pull/665?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4f1c53c) into [master](https://codecov.io/gh/apache/rocketmq-client-go/commit/dfa26d159f9f47cf38c8788dc3ae9443bad61e0d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dfa26d1) will **increase** coverage by `0.17%`.
> The diff coverage is `88.88%`.
[](https://codecov.io/gh/apache/rocketmq-client-go/pull/665?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #665 +/- ##
==========================================
+ Coverage 24.36% 24.54% +0.17%
==========================================
Files 48 48
Lines 5204 5207 +3
==========================================
+ Hits 1268 1278 +10
+ Misses 3726 3722 -4
+ Partials 210 207 -3
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq-client-go/pull/665?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [producer/producer.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/665/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvZHVjZXIvcHJvZHVjZXIuZ28=) | `28.48% <88.88%> (+2.23%)` | :arrow_up: |
| [producer/option.go](https://codecov.io/gh/apache/rocketmq-client-go/pull/665/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvZHVjZXIvb3B0aW9uLmdv) | `42.22% <0.00%> (+4.44%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/665?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq-client-go/pull/665?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [dfa26d1...4f1c53c](https://codecov.io/gh/apache/rocketmq-client-go/pull/665?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org