You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/07/16 03:00:12 UTC
[GitHub] [shardingsphere-elasticjob] rudy2steiner opened a new pull request #1082: CloudJobConfigurationPOJO instead of CloudJobConfiguration
rudy2steiner opened a new pull request #1082:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1082
Fixes #1047.
Changes proposed in this pull request:
- CloudJobConfigurationPOJO instead of CloudJobConfiguration
- Remove useless JobConfigurationGsonTypeAdapter and it's register code
- BootstrapEnvironment load bug fix
make sure conf/elastic-job-cloud-scheduler.properties can be loaded in dev and excluded in the jar
As i know, there is no need to change any frontend code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] terrymanu merged pull request #1082: CloudJobConfigurationPOJO instead of CloudJobConfiguration
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #1082:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1082
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] terrymanu commented on a change in pull request #1082: CloudJobConfigurationPOJO instead of CloudJobConfiguration
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #1082:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1082#discussion_r455494522
##########
File path: elasticjob-cloud/elasticjob-cloud-scheduler/pom.xml
##########
@@ -142,12 +142,21 @@
<directory>src/main/resources</directory>
<excludes>
<exclude>bin/*</exclude>
- <exclude>conf/*</exclude>
<exclude>assembly/*</exclude>
</excludes>
</resource>
</resources>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-jar-plugin</artifactId>
+ <version>2.3.2</version>
Review comment:
Please use dependency management to manage version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] rudy2steiner commented on a change in pull request #1082: CloudJobConfigurationPOJO instead of CloudJobConfiguration
Posted by GitBox <gi...@apache.org>.
rudy2steiner commented on a change in pull request #1082:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1082#discussion_r455497980
##########
File path: elasticjob-cloud/elasticjob-cloud-scheduler/pom.xml
##########
@@ -142,12 +142,21 @@
<directory>src/main/resources</directory>
<excludes>
<exclude>bin/*</exclude>
- <exclude>conf/*</exclude>
<exclude>assembly/*</exclude>
</excludes>
</resource>
</resources>
<plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-jar-plugin</artifactId>
+ <version>2.3.2</version>
Review comment:
Ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org