[GitHub] [kafka] lucasbru commented on a diff in pull request #12908: MINOR: Prevent NPE in SmokeTestDriver (fix flaky test)

[GitBox <gi...@apache.org>]

lucasbru commented on code in PR #12908:
URL: https://github.com/apache/kafka/pull/12908#discussion_r1033809187


##########
streams/src/test/java/org/apache/kafka/streams/tests/SmokeTestDriver.java:
##########
@@ -470,6 +461,18 @@ public static VerificationResult verify(final String kafka,
         return verificationResult;
     }
 
+    private static Map<String, Set<Number>> parseRecordsForEchoTopic(final Map<String, Map<String, LinkedList<ConsumerRecord<String, Number>>>> events) {
+        return events.containsKey("echo") ?

Review Comment:
   nit: This is along expression, I'd prefer to write this with an if-construct, but I won't insist.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org