[GitHub] [spark] zsxwing commented on a change in pull request #27732: [SPARK-30984][SS]Add UI test for Structured Streaming UI

[GitBox <gi...@apache.org>]

zsxwing commented on a change in pull request #27732: [SPARK-30984][SS]Add UI test for Structured Streaming UI
URL: https://github.com/apache/spark/pull/27732#discussion_r386840112
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/streaming/StreamingQueryListener.scala
 ##########
 @@ -82,15 +82,15 @@ object StreamingQueryListener {
    * @param id A unique query id that persists across restarts. See `StreamingQuery.id()`.
    * @param runId A query id that is unique for every start/restart. See `StreamingQuery.runId()`.
    * @param name User-specified name of the query, null if not specified.
-   * @param submissionTime The timestamp to start a query.
+   * @param timestamp The timestamp to start a query.
    * @since 2.1.0
    */
   @Evolving
   class QueryStartedEvent private[sql](
       val id: UUID,
       val runId: UUID,
       val name: String,
-      val submissionTime: Long) extends Event
+      val timestamp: String) extends Event
 
 Review comment:
   Yep, totally agreed that `Long` is better for coding. However, `StreamingQueryProgress#timestamp` was designed to be human readable. In addition, its type cannot be changed now because that's a public API. Since the user has already had codes to parse `StreamingQueryProgress.timestamp`, it should be fine to add a field with the same format.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org