[jira] [Created] (TAP5-2217) JS modules from stack are not added when COMBINE_SCRIPTS is false

["Jochen Kemnade (JIRA)" <ji...@apache.org>]

Jochen Kemnade created TAP5-2217:
------------------------------------

             Summary: JS modules from stack are not added when COMBINE_SCRIPTS is false
                 Key: TAP5-2217
                 URL: https://issues.apache.org/jira/browse/TAP5-2217
             Project: Tapestry 5
          Issue Type: Improvement
          Components: tapestry-core
    Affects Versions: 5.4
            Reporter: Jochen Kemnade
            Priority: Blocker


When COMBINE_SCRIPTS is set to {{false}}, a stack's modules are not added. The problem is that {{org.apache.tapestry5.internal.services.javascript.JavaScriptStackPathConstructorImpl.constructPathsForJavaScriptStack(String)}} only adds the stack's libraries if `combineScripts` is {{false}}.
The problem was introduced in `65d31852d8b4a0691a19736c672fedea9e3179e0}}, by the removal of
{{
        for (String moduleName : stack.getModules())
        {
            require(moduleName);
        }
}}
in `org.apache.tapestry5.internal.services.ajax.JavaScriptSupportImpl.addAssetsFromStack(String)`.



--
This message was sent by Atlassian JIRA
(v6.1#6144)