[GitHub] Menardi opened a new pull request #462: Device: Add unit tests and remove Q

[GitBox <gi...@apache.org>]

Menardi opened a new pull request #462: Device: Add unit tests and remove Q
URL: https://github.com/apache/cordova-android/pull/462
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   ### Platforms affected
   Android
   
   ### What does this PR do?
   The main point of this PR is to increase test coverage of `device.js`. It's gone from 0% to 100% coverage. :)
   
   Since I was going through `device.js` and figuring out how it works, I figured it was a good time to replace Q with native promises, as mentioned in [CB-14158](https://issues.apache.org/jira/browse/CB-14158). I hope this is OK!
   
   ### What testing has been done on this change?
   - Ran device-related commands
   - Ran unit tests
   
   ### Checklist
   - [x] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
   - [x] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
   - [x] Added automated test coverage as appropriate for this change.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org