[GitHub] [arrow] nealrichardson commented on pull request #34576: GH-34519: [C++][R] Fix dataset scans that project the same name as a field

["nealrichardson (via GitHub)" <gi...@apache.org>]

nealrichardson commented on PR #34576:
URL: https://github.com/apache/arrow/pull/34576#issuecomment-1470763485

   > So I don't think R is going to give us left.b in the projection for the scan options.
   
   It would, the join code in R ensures that the join keys are present at the join step, then the select of left.a happens after. Fairly confident we have tests covering this, but easy enough to verify. 
   
   If it helps our confidence in this change, this is essentially restoring the code we had in the R C++ bindings before the most recent change, which instead of copying the code from the R package, it adapted a function that already existed in scanner.cc (and apparently wasn't always right). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org