You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2023/09/05 13:00:30 UTC
[GitHub] [incubator-pekko-grpc] pjfanning opened a new pull request, #175: [DRAFT] gradle 7
pjfanning opened a new pull request, #175:
URL: https://github.com/apache/incubator-pekko-grpc/pull/175
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning commented on a diff in pull request #175: gradle 7
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #175:
URL: https://github.com/apache/incubator-pekko-grpc/pull/175#discussion_r1317137535
##########
gradle-plugin/gradle/wrapper/gradle-wrapper.properties:
##########
@@ -5,4 +5,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-6.9.1-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.2-bin.zip
Review Comment:
there are millions of these files in github - Gradle have not provided a tidier mechanism - I don't want to reinvent Gradle - can we wait for Gradle to make this easier instead of me spending time on it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] raboof commented on a diff in pull request #175: gradle 7
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof commented on code in PR #175:
URL: https://github.com/apache/incubator-pekko-grpc/pull/175#discussion_r1315959889
##########
gradle-plugin/src/test/groovy/func/GradleCompatibilitySpec.groovy:
##########
@@ -42,7 +42,7 @@ class GradleCompatibilitySpec extends BaseSpec {
then:
result.task(":tasks").outcome == TaskOutcome.SUCCESS
where:
- gradleVersion << ["5.6", "5.6.4", "6.9.1"]
+ gradleVersion << ["5.6", "5.6.4", "7.6.2"]
Review Comment:
this looks suspicious - does this mean it also tests "5.6" and "5.6.4"? Are these tests actually ran?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning commented on a diff in pull request #175: gradle 7
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #175:
URL: https://github.com/apache/incubator-pekko-grpc/pull/175#discussion_r1315990070
##########
gradle-plugin/src/test/groovy/func/GradleCompatibilitySpec.groovy:
##########
@@ -42,7 +42,7 @@ class GradleCompatibilitySpec extends BaseSpec {
then:
result.task(":tasks").outcome == TaskOutcome.SUCCESS
where:
- gradleVersion << ["5.6", "5.6.4", "6.9.1"]
+ gradleVersion << ["5.6", "5.6.4", "7.6.2"]
Review Comment:
I'll have a look - it does look like these unit tests may not be part of the CI build
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] He-Pin commented on a diff in pull request #175: gradle 7
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #175:
URL: https://github.com/apache/incubator-pekko-grpc/pull/175#discussion_r1317211903
##########
.github/workflows/build-test.yml:
##########
@@ -153,7 +153,7 @@ jobs:
cp .jvmopts-ci .jvmopts
sbt codegen/publishM2 scalapb-protoc-plugin/publishM2 +runtime/publishM2
cd gradle-plugin
- ./gradlew clean publishToMavenLocal --console=plain --info --stacktrace
+ ./gradlew clean test publishToMavenLocal --console=plain --info --stacktrace
Review Comment:
great!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning merged pull request #175: gradle 7
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #175:
URL: https://github.com/apache/incubator-pekko-grpc/pull/175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] He-Pin commented on a diff in pull request #175: gradle 7
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #175:
URL: https://github.com/apache/incubator-pekko-grpc/pull/175#discussion_r1317214837
##########
gradle-plugin/src/test/groovy/func/GradleCompatibilitySpec.groovy:
##########
@@ -42,7 +42,7 @@ class GradleCompatibilitySpec extends BaseSpec {
then:
result.task(":tasks").outcome == TaskOutcome.SUCCESS
where:
- gradleVersion << ["5.6", "5.6.4", "6.9.1"]
+ gradleVersion << ["5.6", "5.6.4", "7.6.2"]
Review Comment:
As we updated to 7, maybe that should change to tests major versions 5 6 7
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning commented on pull request #175: gradle 7
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on PR #175:
URL: https://github.com/apache/incubator-pekko-grpc/pull/175#issuecomment-1706663988
This helps https://github.com/apache/incubator-pekko-grpc/pull/173/ - seems best still to merge this first and not to bundle the change in 173. I can rebase 173 after this is merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning commented on a diff in pull request #175: gradle 7
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #175:
URL: https://github.com/apache/incubator-pekko-grpc/pull/175#discussion_r1317139836
##########
gradle-plugin/gradle/wrapper/gradle-wrapper.properties:
##########
@@ -5,4 +5,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-6.9.1-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.2-bin.zip
Review Comment:
is sbt any better? we have dozens of build.properties files checked in that all say `sbt.version=1.9.4`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] He-Pin commented on a diff in pull request #175: gradle 7
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #175:
URL: https://github.com/apache/incubator-pekko-grpc/pull/175#discussion_r1317134465
##########
gradle-plugin/gradle/wrapper/gradle-wrapper.properties:
##########
@@ -5,4 +5,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-6.9.1-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.2-bin.zip
Review Comment:
Could we extract the version to a variable? of the URL is stable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko-grpc] pjfanning commented on a diff in pull request #175: gradle 7
Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning commented on code in PR #175:
URL: https://github.com/apache/incubator-pekko-grpc/pull/175#discussion_r1317139836
##########
gradle-plugin/gradle/wrapper/gradle-wrapper.properties:
##########
@@ -5,4 +5,4 @@ distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-6.9.1-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.2-bin.zip
Review Comment:
is sbt any better, we have dozens of build.properties files checked in that all say `sbt.version=1.9.4`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org