[jira] [Closed] (GEODE-7892) Code improvements for ConnectionProxyJUnitTest

["Dave Barnes (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GEODE-7892?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Dave Barnes closed GEODE-7892.
------------------------------

> Code improvements for ConnectionProxyJUnitTest
> ----------------------------------------------
>
>                 Key: GEODE-7892
>                 URL: https://issues.apache.org/jira/browse/GEODE-7892
>             Project: Geode
>          Issue Type: Improvement
>          Components: tests
>            Reporter: Alberto Bustamante Reyes
>            Assignee: Alberto Bustamante Reyes
>            Priority: Trivial
>              Labels: pull-request-available
>             Fix For: 1.13.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> I was taking a look to {{ConnectionProxyJUnitTest}} and I realized that {{verifyAckSend and verifyExpiry methods were not using their timeToWait}} parameter, so in fact they were using the default {{GeodeAwaitability}} timeout value (5 minutes).
> I changed that and then I realized different calls to both methods were using different timeouts. And the one used for {{verifyExpiry}} in {{testPeriodicAckSendByClient}} was causing the test to fail, so I decided to homogenize calls to the same method, using a common timeout (the two new Duration objects in the class).
> And finally I removed the usage of deprecated {{WaitCriterion}} class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)