You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "joyhaldar (via GitHub)" <gi...@apache.org> on 2026/05/16 09:00:03 UTC
[PR] Core, Flink: Add UUID to DataTestBase SUPPORTED_PRIMITIVES [iceberg]
joyhaldar opened a new pull request, #16364:
URL: https://github.com/apache/iceberg/pull/16364
Follow-up to #16097.
Adds a UUID field to `SUPPORTED_PRIMITIVES` in [DataTestBase](https://github.com/apache/iceberg/blob/6976e020b894f6a6777704df2b8c4458cb291ae9/core/src/test/java/org/apache/iceberg/data/DataTestBase.java#L86). `UUID` was only tested in Flink's [TestFlinkUuidType](https://github.com/apache/iceberg/blob/main/flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/TestFlinkUuidType.java) before. Now every test that extends `DataTestBase` reads and writes `UUID` too.
[TestFlinkParquetReader](https://github.com/apache/iceberg/blob/6976e020b894f6a6777704df2b8c4458cb291ae9/flink/v2.1/flink/src/test/java/org/apache/iceberg/flink/data/TestFlinkParquetReader.java#L61) extends `DataTestBase` and has a test with a Parquet schema written out by hand to match `SUPPORTED_PRIMITIVES`. Updated that schema to add the `UUID` column, for Flink `2.1`, `2.0` and `1.20`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core, Flink: Add UUID to DataTestBase SUPPORTED_PRIMITIVES [iceberg]
Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary commented on PR #16364:
URL: https://github.com/apache/iceberg/pull/16364#issuecomment-4475699259
Merged to main.
Thanks @joyhaldar for extending the tests!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core, Flink: Add UUID to DataTestBase SUPPORTED_PRIMITIVES [iceberg]
Posted by "pvary (via GitHub)" <gi...@apache.org>.
pvary merged PR #16364:
URL: https://github.com/apache/iceberg/pull/16364
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] Core, Flink: Add UUID to DataTestBase SUPPORTED_PRIMITIVES [iceberg]
Posted by "joyhaldar (via GitHub)" <gi...@apache.org>.
joyhaldar commented on PR #16364:
URL: https://github.com/apache/iceberg/pull/16364#issuecomment-4468841727
cc: @pvary, @Guosmilesmile, @mxm
As we discussed on #16097, this adds `UUID` to `SUPPORTED_PRIMITIVES` in [DataTestBase](https://github.com/apache/iceberg/blob/6976e020b894f6a6777704df2b8c4458cb291ae9/core/src/test/java/org/apache/iceberg/data/DataTestBase.java#L86) so it's covered across all the subclasses. I'd be grateful if you could take a look when you have time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org