You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Henning P. Schmiedehausen" <hp...@intermeta.de> on 2003/08/18 23:48:49 UTC
[PATCH MAVEN_RC1_STABLE] maven-torque-plugin
Hi,
I seem to be the only one actually using this plugin. Or everyone else
never really rebuilds maven from scratch and keeps old plugins laying
around so that some pathes and / or jar dependencies work by accident.
The following patch is needed for me to get the maven-torque-plugin
functional again in the MAVEN_RC1_STABLE branch when building maven
into a fresh $MAVEN_HOME from scratch. Please apply.
- correct the dependency names for xml-apis and torque:torque-gen
(didn't load before, worked by accident if the project had the same
jars on its classpath.)
- Load the plugin.properties from the _right_ path. The plugin is under
3.2-SNAPSHOT, not 3.1
- The "latest and greatest" Velocity-1.4-dev seems to have huge problems
loading its templates from the classpath. Go back to 1.3.1 which works
fine.
With this patch, I'm actually able to build the current Turbine base again
with a current maven. All changes are obvious. Please apply.
Regards
Henning
diff -urb maven/src/plugins-build/torque/plugin.jelly /home/henning/.maven/plugins/maven-torque-plugin-3.2-SNAPSHOT/plugin.jelly
--- maven/src/plugins-build/torque/plugin.jelly 2003-08-07 19:00:54.000000000 +0200
+++ /home/henning/.maven/plugins/maven-torque-plugin-3.2-SNAPSHOT/plugin.jelly 2003-08-18 23:42:00.000000000 +0200
@@ -31,8 +31,8 @@
<pathelement path="${plugin.getDependencyPath('velocity')}"/>
<pathelement path="${plugin.getDependencyPath('village')}"/>
<pathelement path="${plugin.getDependencyPath('xercesImpl')}"/>
- <pathelement path="${plugin.getDependencyPath('xmlParserAPIs')}"/>
- <pathelement path="${plugin.getDependencyPath('torque-gen')}"/>
+ <pathelement path="${plugin.getDependencyPath('xml-apis')}"/>
+ <pathelement path="${plugin.getDependencyPath('torque:torque-gen')}"/>
<pathelement path="${pom.getDependencyClasspath()}"/>
<path refid="maven.dependency.classpath"/>
</path>
@@ -42,7 +42,7 @@
Note: I have no idea why this file is not already processed by the plugin..
-->
- <property file="${maven.plugin.dir}/maven-torque-plugin-3.1/plugin.properties"/>
+ <property file="${maven.plugin.dir}/maven-torque-plugin-3.2-SNAPSHOT/plugin.properties"/>
<!-- Define all of the tasks -->
<taskdef
diff -urb maven/src/plugins-build/torque/project.xml /home/henning/.maven/plugins/maven-torque-plugin-3.2-SNAPSHOT/project.xml
--- maven/src/plugins-build/torque/project.xml 2003-07-25 08:35:27.000000000 +0200
+++ /home/henning/.maven/plugins/maven-torque-plugin-3.2-SNAPSHOT/project.xml 2003-08-18 23:41:28.000000000 +0200
@@ -123,7 +123,7 @@
</dependency>
<dependency>
<id>velocity</id>
- <version>1.4-dev</version>
+ <version>1.3.1</version>
<properties>
<classloader>root</classloader>
</properties>
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
hps@intermeta.de +49 9131 50 654 0 http://www.intermeta.de/
Java, perl, Solaris, Linux, xSP Consulting, Web Services
freelance consultant -- Jakarta Turbine Development -- hero for hire
"Dominate!! Dominate!! Eat your young and aggregate! I have grotty silicon!"
-- AOL CD when played backwards (User Friendly - 200-10-15)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [PATCH MAVEN_RC1_STABLE] maven-torque-plugin
Posted by di...@multitask.com.au.
"Henning P. Schmiedehausen" <hp...@intermeta.de> wrote on 19/08/2003
05:44:09 PM:
> dion@multitask.com.au writes:
>
> >Raised as MAVEN-690.
>
> >Things would be so much easier if the patch was an attachment and filed
in
> >Jira....
>
> Yes,
>
> things would be so much easier if the plugin authors would care about
> these tiny little things.
It would indeed.
> I didn't just raise a "it does not work". I looked at this code (even
> though I'm just a maven user, not a maven developer) and provided a
> patch with explanations why something does not work. What else do you
> expect?
Expect? Nothing more.
Want? That's a different story.
>
> Regards
> Henning
--
dIon Gillard, Multitask Consulting
Blog: http://blogs.codehaus.org/people/dion/
Re: [PATCH MAVEN_RC1_STABLE] maven-torque-plugin
Posted by "Henning P. Schmiedehausen" <hp...@intermeta.de>.
dion@multitask.com.au writes:
>--=_alternative 0006BE6FCA256D87_=
>Content-Type: text/plain; charset="US-ASCII"
>Raised as MAVEN-690.
>Things would be so much easier if the patch was an attachment and filed in
>Jira....
Yes,
things would be so much easier if the plugin authors would care about
these tiny little things.
I didn't just raise a "it does not work". I looked at this code (even
though I'm just a maven user, not a maven developer) and provided a
patch with explanations why something does not work. What else do you
expect?
Regards
Henning
>--
>dIon Gillard, Multitask Consulting
>Blog: http://blogs.codehaus.org/people/dion/
>"Henning P. Schmiedehausen" <hp...@intermeta.de> wrote on 19/08/2003
>07:48:49 AM:
>> Hi,
>>
>> I seem to be the only one actually using this plugin. Or everyone else
>> never really rebuilds maven from scratch and keeps old plugins laying
>> around so that some pathes and / or jar dependencies work by accident.
>>
>> The following patch is needed for me to get the maven-torque-plugin
>> functional again in the MAVEN_RC1_STABLE branch when building maven
>> into a fresh $MAVEN_HOME from scratch. Please apply.
>>
>> - correct the dependency names for xml-apis and torque:torque-gen
>> (didn't load before, worked by accident if the project had the same
>> jars on its classpath.)
>>
>> - Load the plugin.properties from the _right_ path. The plugin is under
>> 3.2-SNAPSHOT, not 3.1
>>
>> - The "latest and greatest" Velocity-1.4-dev seems to have huge problems
>> loading its templates from the classpath. Go back to 1.3.1 which works
>> fine.
>>
>> With this patch, I'm actually able to build the current Turbine base
>again
>> with a current maven. All changes are obvious. Please apply.
>>
>> Regards
>> Henning
>>
>>
>> diff -urb maven/src/plugins-build/torque/plugin.jelly
>>
>/home/henning/.maven/plugins/maven-torque-plugin-3.2-SNAPSHOT/plugin.jelly
>> --- maven/src/plugins-build/torque/plugin.jelly 2003-08-07 19:00:
>> 54.000000000 +0200
>> +++ /home/henning/.maven/plugins/maven-torque-plugin-3.2-
>> SNAPSHOT/plugin.jelly 2003-08-18 23:42:00.000000000 +0200
>> @@ -31,8 +31,8 @@
>> <pathelement path="${plugin.getDependencyPath('velocity')}"/>
>> <pathelement path="${plugin.getDependencyPath('village')}"/>
>> <pathelement path="${plugin.getDependencyPath('xercesImpl')}"/>
>> - <pathelement
>path="${plugin.getDependencyPath('xmlParserAPIs')}"/>
>> - <pathelement path="${plugin.getDependencyPath('torque-gen')}"/>
>> + <pathelement path="${plugin.getDependencyPath('xml-apis')}"/>
>> + <pathelement
>path="${plugin.getDependencyPath('torque:torque-gen')}"/>
>> <pathelement path="${pom.getDependencyClasspath()}"/>
>> <path refid="maven.dependency.classpath"/>
>> </path>
>> @@ -42,7 +42,7 @@
>>
>> Note: I have no idea why this file is not already
>> processed by the plugin..
>> -->
>> - <property file="${maven.plugin.dir}/maven-torque-plugin-3.
>> 1/plugin.properties"/>
>> + <property file="${maven.plugin.dir}/maven-torque-plugin-3.2-
>> SNAPSHOT/plugin.properties"/>
>>
>> <!-- Define all of the tasks -->
>> <taskdef
>> diff -urb maven/src/plugins-build/torque/project.xml /home/henning/.
>> maven/plugins/maven-torque-plugin-3.2-SNAPSHOT/project.xml
>> --- maven/src/plugins-build/torque/project.xml 2003-07-25 08:35:
>> 27.000000000 +0200
>> +++ /home/henning/.maven/plugins/maven-torque-plugin-3.2-
>> SNAPSHOT/project.xml 2003-08-18 23:41:28.000000000 +0200
>> @@ -123,7 +123,7 @@
>> </dependency>
>> <dependency>
>> <id>velocity</id>
>> - <version>1.4-dev</version>
>> + <version>1.3.1</version>
>> <properties>
>> <classloader>root</classloader>
>> </properties>
>> --
>> Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
>> hps@intermeta.de +49 9131 50 654 0 http://www.intermeta.de/
>>
>> Java, perl, Solaris, Linux, xSP Consulting, Web Services
>> freelance consultant -- Jakarta Turbine Development -- hero for hire
>>
>> "Dominate!! Dominate!! Eat your young and aggregate! I have grotty
>silicon!"
>> -- AOL CD when played backwards (User Friendly - 200-10-15)
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>--=_alternative 0006BE6FCA256D87_=--
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
hps@intermeta.de +49 9131 50 654 0 http://www.intermeta.de/
Java, perl, Solaris, Linux, xSP Consulting, Web Services
freelance consultant -- Jakarta Turbine Development -- hero for hire
"Dominate!! Dominate!! Eat your young and aggregate! I have grotty silicon!"
-- AOL CD when played backwards (User Friendly - 200-10-15)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: [PATCH MAVEN_RC1_STABLE] maven-torque-plugin
Posted by di...@multitask.com.au.
Raised as MAVEN-690.
Things would be so much easier if the patch was an attachment and filed in
Jira....
--
dIon Gillard, Multitask Consulting
Blog: http://blogs.codehaus.org/people/dion/
"Henning P. Schmiedehausen" <hp...@intermeta.de> wrote on 19/08/2003
07:48:49 AM:
> Hi,
>
> I seem to be the only one actually using this plugin. Or everyone else
> never really rebuilds maven from scratch and keeps old plugins laying
> around so that some pathes and / or jar dependencies work by accident.
>
> The following patch is needed for me to get the maven-torque-plugin
> functional again in the MAVEN_RC1_STABLE branch when building maven
> into a fresh $MAVEN_HOME from scratch. Please apply.
>
> - correct the dependency names for xml-apis and torque:torque-gen
> (didn't load before, worked by accident if the project had the same
> jars on its classpath.)
>
> - Load the plugin.properties from the _right_ path. The plugin is under
> 3.2-SNAPSHOT, not 3.1
>
> - The "latest and greatest" Velocity-1.4-dev seems to have huge problems
> loading its templates from the classpath. Go back to 1.3.1 which works
> fine.
>
> With this patch, I'm actually able to build the current Turbine base
again
> with a current maven. All changes are obvious. Please apply.
>
> Regards
> Henning
>
>
> diff -urb maven/src/plugins-build/torque/plugin.jelly
>
/home/henning/.maven/plugins/maven-torque-plugin-3.2-SNAPSHOT/plugin.jelly
> --- maven/src/plugins-build/torque/plugin.jelly 2003-08-07 19:00:
> 54.000000000 +0200
> +++ /home/henning/.maven/plugins/maven-torque-plugin-3.2-
> SNAPSHOT/plugin.jelly 2003-08-18 23:42:00.000000000 +0200
> @@ -31,8 +31,8 @@
> <pathelement path="${plugin.getDependencyPath('velocity')}"/>
> <pathelement path="${plugin.getDependencyPath('village')}"/>
> <pathelement path="${plugin.getDependencyPath('xercesImpl')}"/>
> - <pathelement
path="${plugin.getDependencyPath('xmlParserAPIs')}"/>
> - <pathelement path="${plugin.getDependencyPath('torque-gen')}"/>
> + <pathelement path="${plugin.getDependencyPath('xml-apis')}"/>
> + <pathelement
path="${plugin.getDependencyPath('torque:torque-gen')}"/>
> <pathelement path="${pom.getDependencyClasspath()}"/>
> <path refid="maven.dependency.classpath"/>
> </path>
> @@ -42,7 +42,7 @@
>
> Note: I have no idea why this file is not already
> processed by the plugin..
> -->
> - <property file="${maven.plugin.dir}/maven-torque-plugin-3.
> 1/plugin.properties"/>
> + <property file="${maven.plugin.dir}/maven-torque-plugin-3.2-
> SNAPSHOT/plugin.properties"/>
>
> <!-- Define all of the tasks -->
> <taskdef
> diff -urb maven/src/plugins-build/torque/project.xml /home/henning/.
> maven/plugins/maven-torque-plugin-3.2-SNAPSHOT/project.xml
> --- maven/src/plugins-build/torque/project.xml 2003-07-25 08:35:
> 27.000000000 +0200
> +++ /home/henning/.maven/plugins/maven-torque-plugin-3.2-
> SNAPSHOT/project.xml 2003-08-18 23:41:28.000000000 +0200
> @@ -123,7 +123,7 @@
> </dependency>
> <dependency>
> <id>velocity</id>
> - <version>1.4-dev</version>
> + <version>1.3.1</version>
> <properties>
> <classloader>root</classloader>
> </properties>
> --
> Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
> hps@intermeta.de +49 9131 50 654 0 http://www.intermeta.de/
>
> Java, perl, Solaris, Linux, xSP Consulting, Web Services
> freelance consultant -- Jakarta Turbine Development -- hero for hire
>
> "Dominate!! Dominate!! Eat your young and aggregate! I have grotty
silicon!"
> -- AOL CD when played backwards (User Friendly - 200-10-15)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>