You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/09/23 01:33:36 UTC
[GitHub] [cloudstack-primate] nvazquez opened a new pull request #737: Hide root disk controller, nic adapter and guest OS when registering deploy as is template
nvazquez opened a new pull request #737:
URL: https://github.com/apache/cloudstack-primate/pull/737
Deploy as is template must not allow selecting:
- Root disk controller
- NIC adapter type
- Guest OS
That information is obtained from the OVF as-is
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] andrijapanicsb commented on pull request #737: Hide root disk controller, nic adapter and guest OS when registering deploy as is template
Posted by GitBox <gi...@apache.org>.
andrijapanicsb commented on pull request #737:
URL: https://github.com/apache/cloudstack-primate/pull/737#issuecomment-697477397
LGTM
(though it is just a partial solution - hiding those while regiostering template, but can be added later in tempalte/VM details etc.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #737: Hide root disk controller, nic adapter and guest OS when registering deploy as is template
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #737:
URL: https://github.com/apache/cloudstack-primate/pull/737#issuecomment-697148196
LGTM
Need second pair of eyes, @davidjumani can you review this?
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #737: Hide root disk controller, nic adapter and guest OS when registering deploy as is template
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #737:
URL: https://github.com/apache/cloudstack-primate/pull/737
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #737: Hide root disk controller, nic adapter and guest OS when registering deploy as is template
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #737:
URL: https://github.com/apache/cloudstack-primate/pull/737#issuecomment-697148282
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #737: Hide root disk controller, nic adapter and guest OS when registering deploy as is template
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #737:
URL: https://github.com/apache/cloudstack-primate/pull/737#issuecomment-697284475
LGTM @andrijapanicsb can you test latest master now, thnx
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #737: Hide root disk controller, nic adapter and guest OS when registering deploy as is template
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #737:
URL: https://github.com/apache/cloudstack-primate/pull/737#issuecomment-697152477
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/737 (JID-3500)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #737: Hide root disk controller, nic adapter and guest OS when registering deploy as is template
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #737:
URL: https://github.com/apache/cloudstack-primate/pull/737#issuecomment-697148478
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org