You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/12/24 08:03:12 UTC

[GitHub] [pulsar] dockerzhang opened a new pull request #9049: add updateRates method for kop to collect publish rate

dockerzhang opened a new pull request #9049:
URL: https://github.com/apache/pulsar/pull/9049


   
   Fixes #9048 
   
   ### Motivation
   kop & pulsar use the same metrics collector, but kop can't collect publish rate now.
   https://github.com/streamnative/kop/issues/284
   
   ### Modifications
   
   add `updateRates` method for kop to collect publish rate
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   *(Please pick either of the following options)*
   
   This change is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This change is already covered by existing tests, such as *(please describe tests)*.
   
   *(or)*
   
   This change added tests and can be verified as follows:
   
   *(example:)*
     - *Added integration tests for end-to-end deployment with large payloads (10MB)*
     - *Extended integration test for recovery after broker failure*


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] dockerzhang commented on pull request #9049: add updateRates method for kop to collect publish rate

Posted by GitBox <gi...@apache.org>.
dockerzhang commented on pull request #9049:
URL: https://github.com/apache/pulsar/pull/9049#issuecomment-750851586


   /pulsarbot run-failure-checks


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] codelipenghui merged pull request #9049: add updateRates method for kop to collect publish rate

Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #9049:
URL: https://github.com/apache/pulsar/pull/9049


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org