[GitHub] sijie commented on a change in pull request #1251: BP-29 (task 4): use metadata service uri for constructing registration manager and ledger manager factory

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #1251: BP-29 (task 4): use metadata service uri for constructing registration manager and ledger manager factory
URL: https://github.com/apache/bookkeeper/pull/1251#discussion_r174965291
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/AbstractConfiguration.java
 ##########
 @@ -204,7 +204,8 @@ public String getMetadataServiceUri() throws ConfigurationException {
             String ledgerManagerType;
             Class<? extends LedgerManagerFactory> factoryClass = getLedgerManagerFactoryClass();
             if (factoryClass == null) {
-                ledgerManagerType = HierarchicalLedgerManagerFactory.NAME;
+                // set the ledger manager type to "null", so the driver implementation knows that the type is not set.
+                ledgerManagerType = "null";
 
 Review comment:
   "zk+null" comes from bc + testing and used internally when `metadataServiceUri` is not provided. by default user should "zk://..." for the purpose of "auto". I don't want to introduce a concept called "auto", which is confusing.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services