Re: [PR] [ISSUE #5039]support full sync of mysql (eventmesh)

["Pil0tXia (via GitHub)" <gi...@apache.org>]

Pil0tXia commented on code in PR #5038:
URL: https://github.com/apache/eventmesh/pull/5038#discussion_r1687979992


##########
eventmesh-admin-server/build.gradle:
##########
@@ -31,18 +31,25 @@ dependencies {
     implementation "io.grpc:grpc-stub"
     implementation "io.grpc:grpc-netty-shaded"
 
-    // https://mvnrepository.com/artifact/com.baomidou/mybatis-plus-boot-starter
-    implementation 'com.baomidou:mybatis-plus-boot-starter:3.5.7'
-    implementation "org.reflections:reflections:0.10.2"
+	// https://mvnrepository.com/artifact/com.baomidou/mybatis-plus-boot-starter
+	implementation "com.baomidou:mybatis-plus-boot-starter"
 
-    // https://mvnrepository.com/artifact/com.alibaba/druid-spring-boot-starter
-    implementation "com.alibaba:druid-spring-boot-starter"
-    compileOnly 'com.mysql:mysql-connector-j'
-    compileOnly 'org.projectlombok:lombok'
-    annotationProcessor 'org.projectlombok:lombok'
+	// https://mvnrepository.com/artifact/com.alibaba/druid-spring-boot-starter
+	implementation "com.alibaba:druid-spring-boot-starter"
+	implementation 'com.mysql:mysql-connector-j'
+	compileOnly 'org.projectlombok:lombok'

Review Comment:
   `mysql-connector-j` artifact with `implementation` namespace introduces incompatible license.
   
   I will submit a PR and add `The GNU General Public License, v2 with Universal FOSS Exception, v1.0` in `deniedLicenses` later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org