You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2018/05/04 03:39:16 UTC

Re: Review Request 66749: Added more logging to agent recovery path.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66749/#review202410
-----------------------------------------------------------


Fix it, then Ship it!





src/slave/containerizer/docker.cpp
Lines 913 (patched)
<https://reviews.apache.org/r/66749/#comment284228>

    Got the list of Docker containers


- Chun-Hung Hsiao


On April 23, 2018, 10:30 p.m., Meng Zhu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66749/
> -----------------------------------------------------------
> 
> (Updated April 23, 2018, 10:30 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann.
> 
> 
> Bugs: MESOS-8793
>     https://issues.apache.org/jira/browse/MESOS-8793
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added logging in some agent recovery continuations to
> make analyzing agent recovery related issue less painful.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/composing.cpp 186102c66d373dcd799cadd9fed7d1c8cb894971 
>   src/slave/containerizer/docker.cpp a4c9c10e91e75f406329cbb2086f39b549cbeed0 
>   src/slave/containerizer/mesos/containerizer.cpp def09f1104213bf73d9f95cb5ad2fb80e3bdb04a 
>   src/slave/containerizer/mesos/linux_launcher.cpp af34a856e092a880a0809da34ead9d8588b0ac8f 
>   src/slave/slave.cpp 9d2d1928b231044988f1855eb518448db38ff04f 
> 
> 
> Diff: https://reviews.apache.org/r/66749/diff/2/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>