[jira] [Commented] (RATIS-605) Change RaftServerImpl and proto to use RaftGroupMemberId

["Tsz Wo Nicholas Sze (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/RATIS-605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16879091#comment-16879091 ] 

Tsz Wo Nicholas Sze commented on RATIS-605:
-------------------------------------------

{quote}
> b) Raft.proto:39, can peer bytes converted to another proto message
This is a good suggestion. We may do it separately. It is going to make the patch huge again.
{quote}
Filed RATIS-612.
{quote}
> c) Lets also look into callers of getId(), i.e. FollowerState, LeaderState & GrpcLogAppender and lets check all the callers of getId() and getGroupId(). These can also be done in a followup patch as well.
Yes, they were already done in the earlier huge patches. I reverted them to keep the patch small.
{quote}
The LogAppender and GrpcLogAppender can be found in RATIS-611.

> Change RaftServerImpl and proto to use RaftGroupMemberId
> --------------------------------------------------------
>
>                 Key: RATIS-605
>                 URL: https://issues.apache.org/jira/browse/RATIS-605
>             Project: Ratis
>          Issue Type: Improvement
>          Components: server
>            Reporter: Tsz Wo Nicholas Sze
>            Assignee: Tsz Wo Nicholas Sze
>            Priority: Major
>             Fix For: 0.4.0
>
>         Attachments: r605_20190627.patch, r605_20190628.patch, r605_20190628b.patch, r605_20190628c.patch, r605_20190629.patch, r605_20190629b.patch, r605_20190703.patch, r605_20190703b.patch, r605_20190703c.patch
>
>
> In multi-raft, a server may belong to more than one groups so that the RaftPeerId is not enough to identity a particular group that the server belong to.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)