You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2019/02/13 02:03:50 UTC
Re: Review Request 69872: Accounted for possible lack of OperationID
in RP responses.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69872/
-----------------------------------------------------------
(Updated Feb. 12, 2019, 6:03 p.m.)
Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
Changes
-------
Moved the code up a bit.
Repository: mesos
Description
-------
Operations sent to a resource provider may include an OperationID
in addition to an Operation UUID. The UUID is sufficient to uniquely
identify the operation, so it is possible for the resource provider
to omit the OperationID in its responses to the agent.
This commit lets the agent fill in any missing ID before updates
are acted upon, such as being sent to the master.
Diffs (updated)
-----
src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79
Diff: https://reviews.apache.org/r/69872/diff/2/
Changes: https://reviews.apache.org/r/69872/diff/1-2/
Testing
-------
Ran the test here (https://reviews.apache.org/r/69869/diff/1) to get past line 11692.
I can probably repurpose that test, if we don't have a CREATE_DISK + feedback test already.
Thanks,
Joseph Wu
Re: Review Request 69872: Accounted for possible lack of OperationID
in RP responses.
Posted by Greg Mann <gr...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69872/#review213178
-----------------------------------------------------------
Ship it!
Ship It!
- Greg Mann
On Feb. 22, 2019, 12:08 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69872/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2019, 12:08 a.m.)
>
>
> Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
>
>
> Bugs: MESOS-9542
> https://issues.apache.org/jira/browse/MESOS-9542
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Operations sent to a resource provider may include an OperationID
> in addition to an Operation UUID. The UUID is sufficient to uniquely
> identify the operation, so it is possible for the resource provider
> to omit the OperationID in its responses to the agent.
>
> This commit lets the agent fill in any missing ID before updates
> are acted upon, such as being sent to the master.
>
>
> Diffs
> -----
>
> src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79
>
>
> Diff: https://reviews.apache.org/r/69872/diff/2/
>
>
> Testing
> -------
>
> Ran the test here (https://reviews.apache.org/r/69869/diff/1) to get past line 11692.
>
> That test is rewritten in the subsequent diff though.
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 69872: Accounted for possible lack of OperationID
in RP responses.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69872/
-----------------------------------------------------------
(Updated Feb. 21, 2019, 4:08 p.m.)
Review request for mesos, Benno Evers, Gastón Kleiman, and Greg Mann.
Changes
-------
Added this to the chain of orphan operation patches. Mostly related to tests.
Bugs: MESOS-9542
https://issues.apache.org/jira/browse/MESOS-9542
Repository: mesos
Description
-------
Operations sent to a resource provider may include an OperationID
in addition to an Operation UUID. The UUID is sufficient to uniquely
identify the operation, so it is possible for the resource provider
to omit the OperationID in its responses to the agent.
This commit lets the agent fill in any missing ID before updates
are acted upon, such as being sent to the master.
Diffs
-----
src/slave/slave.cpp e3c2c005d865b5c333e92e50e49ef398fe06ad79
Diff: https://reviews.apache.org/r/69872/diff/2/
Testing (updated)
-------
Ran the test here (https://reviews.apache.org/r/69869/diff/1) to get past line 11692.
That test is rewritten in the subsequent diff though.
Thanks,
Joseph Wu