You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by shijinkui <gi...@git.apache.org> on 2016/09/02 03:17:19 UTC
[GitHub] flink pull request #2459: [FLINK-4561] replace all the scala version as a `s...
GitHub user shijinkui opened a pull request:
https://github.com/apache/flink/pull/2459
[FLINK-4561] replace all the scala version as a `scala.binary.version` property
Replace all the scala version(2.10) as a property `scala.binary.version` defined in root pom properties. default scala version property is 2.10.
modify:
1. dependency include scala version
2. module defining include scala version
3. scala version upgrade to 2.11.8 from 2.11.7
Only modify pom file.
The pull request references the related JIRA issue ("[FLINK-4561] replace all the scala version as a `scala.binary.version` property")
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shijinkui/flink scala_version_property_replace
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2459.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2459
----
commit e8feaabcb4dc853c6e5b895c2351ea3d96351096
Author: shijinkui <sh...@huawei.com>
Date: 2016-09-02T03:14:07Z
[FLINK-4561] replace all the scala version as a `scala.binary.version` property
replace all the scala version(2.10) as a property `scala.binary.version` defined in root pom properties. default scala version property is 2.10.
modify:
1. dependency include scala version
2. module defining include scala version
3. scala version upgrade to 2.11.8 from 2.11.7
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2459: [FLINK-4561] replace all the scala version as a `s...
Posted by shijinkui <gi...@git.apache.org>.
Github user shijinkui closed the pull request at:
https://github.com/apache/flink/pull/2459
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2459: [FLINK-4561] replace all the scala version as a `scala.bi...
Posted by shijinkui <gi...@git.apache.org>.
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2459
hi, @StephanEwen I have an idea in mind, If there are to much tricky bugs, and follow "don't change it unless it is broken", after two years can you image the code like? Full of tricky bugs fix.
I think we should make the code robust, reasonable and readable.
Can we make a long plan with many sub-tasks to reach the above purpose?
Such as reduce the unnecessary module, pom more simple and easy maintain the pom.xml
Many people consider the Flink code confused and then give up Flink. I think Flink's features in whole are better, the detail of project need enhance.
How do you think about that?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2459: [FLINK-4561] replace all the scala version as a `scala.bi...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2459
@shijinkui I understand your motivation, it is a good idea in general. Please do not feel discouraged to suggest improvements.
There are some things that look like they could be done better, but actually cannot be changed, because of some tricky bugs or limitations in other parts (like build plugins). That was the case here, so sometimes we cannot change some things.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2459: [FLINK-4561] replace all the scala version as a `scala.bi...
Posted by chiwanpark <gi...@git.apache.org>.
Github user chiwanpark commented on the issue:
https://github.com/apache/flink/pull/2459
Hi @shijinkui, thanks for opening pull request. Unfortunately, this pull request cause a problem with maven shading plugin (https://issues.apache.org/jira/browse/MSHADE-200). Due to the problem, Flink community decided to use version string instead of property and add to a shell script (tools/change-scala-version.sh) to convert Scala version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2459: [FLINK-4561] replace all the scala version as a `scala.bi...
Posted by shijinkui <gi...@git.apache.org>.
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2459
@StephanEwen I can accept "don't change it unless it is broken".
I explain why I made such a insipid and too much changes PR. I have such habit, that is the code need continuous improvement and refactor until have no any improvement at this time. That's why i doesn't want to tolerate bad smell code.
I think such matter belong to myself' habit. The others like this PR are generated conveniently when I read Flink code. These PRs are not important, can be close at any time.
\uff1a\uff09
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2459: [FLINK-4561] replace all the scala version as a `scala.bi...
Posted by shijinkui <gi...@git.apache.org>.
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2459
@StephanEwen Thank for your reply, understand it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2459: [FLINK-4561] replace all the scala version as a `scala.bi...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2459
Yes, @chiwanpark is right. This does not work, we tried it before. As long as the Maven Shade plugin is not fixed, we need to keep it as it is.
Could you close this pull request?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2459: [FLINK-4561] replace all the scala version as a `scala.bi...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2459
I would really like to not change the way it is done right now.
It works and it is the result of many user interactions, testing across Maven, SBT, Gradle, etc.
These various build systems have such subtle differences that I think we should stick with paradigm of "don't change it unless it is broken".
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2459: [FLINK-4561] replace all the scala version as a `scala.bi...
Posted by shijinkui <gi...@git.apache.org>.
Github user shijinkui commented on the issue:
https://github.com/apache/flink/pull/2459
@chiwanpark @StephanEwen thanks for the reply. dependency's version which contain scala 2.10 replace as property?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---