[GitHub] [hbase] frostruan commented on a diff in pull request #4863: HBASE-27463 Reset sizeOfLogQueue when refresh replication source

[GitBox <gi...@apache.org>]

frostruan commented on code in PR #4863:
URL: https://github.com/apache/hbase/pull/4863#discussion_r1014560264


##########
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/regionserver/ReplicationSourceManager.java:
##########
@@ -467,6 +467,9 @@ public void refreshSources(String peerId) throws IOException {
       ReplicationSourceInterface toRemove = this.sources.put(peerId, src);
       if (toRemove != null) {
         LOG.info("Terminate replication source for " + toRemove.getPeerId());
+        // Reset sizeOfLogQueue, log will re enqueue to the created new source.
+        toRemove.getSourceMetrics()

Review Comment:
   Thanks for reviewing @shahrs87 
   
   Currently we monitor the replication status by the sizeOfLogQueue metric, so I just reset the sizeOfLogQueue here. I'll check if there is any other metrics need to be reset. Thanks for your suggestion.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org