You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Neels Janosch Hofmeyr <ne...@elego.de> on 2008/08/20 22:10:37 UTC
treeconflicts patch: cosmetic: another missing separator line.
On the tree-conflicts branch only.
[[[
* subversion/tests/cmdline/merge_tests.py: Add a missing
separator line.
]]]
Index: subversion/tests/cmdline/merge_tests.py
===================================================================
--- subversion/tests/cmdline/merge_tests.py (revision 32607)
+++ subversion/tests/cmdline/merge_tests.py (working copy)
@@ -12809,6 +12809,7 @@
os.chdir(saved_cwd)
+#----------------------------------------------------------------------
# Helper for text output.
def verify_lines(lines, regexes):
"""Return True if each of the given regular expressions matches
--
Neels Hofmeyr -- elego Software Solutions GmbH
Gustav-Meyer-Allee 25 / Gebäude 12, 13355 Berlin, Germany
phone: +49 30 23458696 mobile: +49 177 2345869 fax: +49 30 23458695
http://www.elegosoft.com | Geschäftsführer: Olaf Wagner | Sitz: Berlin
Handelsreg: Amtsgericht Charlottenburg HRB 77719 | USt-IdNr: DE163214194
Re: treeconflicts patch: cosmetic: another missing separator line.
Posted by Karl Fogel <kf...@red-bean.com>.
Neels Janosch Hofmeyr <ne...@elego.de> writes:
>> 2. Do you really need to send a patch for every missing separator line?
>> Remember that not every typo, bad indentation, and strcmp()-that-violates-
>> the-recommended-style (when we still had one) deserves a patch post. :)
>
> True. kfogel, on the other hand, committed such a patch... I can't commit,
> so I can only post changes or ignore them. I figured you'd just choose to
> ignore the post. Should I just ignore these kinds of errors, instead?
I'd say just ignore these cosmetic problems. They're not worth the
overhead of posting a patch, having someone else review it, commit it,
and follow up. (I committed that one since you posted it, but yeah, in
general I think we don't need to clean out every closet in the code.)
> So, a proper subject line for a patch destined for the tree-conflicts branch
> should be
>
> [PATCH] tree-conflicts: foo bar yada
>
> ? I previously thought I should keep tree-conflicts branch stuff a little
> less loud, as in lower-case non-tagged, to not bother you with it.
Any patch should start with "[PATCH]", yes. The above looks good.
Best,
-Karl
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: treeconflicts patch: cosmetic: another missing separator line.
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
Neels Janosch Hofmeyr wrote on Fri, 22 Aug 2008 at 00:56 +0200:
> Hi Daniel!
>
> Daniel Shahaf wrote:
> > 2. Do you really need to send a patch for every missing separator line?
> > Remember that not every typo, bad indentation, and strcmp()-that-violates-
> > the-recommended-style (when we still had one) deserves a patch post. :)
>
> True. kfogel, on the other hand, committed such a patch... I can't commit,
> so I can only post changes or ignore them. I figured you'd just choose to
> ignore the post. Should I just ignore these kinds of errors, instead?
>
Personally, before I became committer, I defaulted to ignoring these.
If you decide not to ignore them, you can group them into one submission.
(For example, when we have a "Strip trailing whitespace" commit, it
usually touches the entire tree, {tools,contrib,subversion}/**.)
This applies just to "cosmetic" patches, of course. Patches that change
the semantics of the code or the public API are not cosmetic.
> >
> > 3. Also, could you use tags properly in your subject lines? To me,
> > "treeconflicts patch: cosmetic:" is three long words that I have to
> > actually *read* :) (before I decide I'm not interested in the thread
> > they're on), while the "[PATCH]" and "tree-conflicts" tags are
> > comparatively easier to recognize.
>
> So, a proper subject line for a patch destined for the tree-conflicts branch
> should be
>
> [PATCH] tree-conflicts: foo bar yada
>
> ?
It uses both tags right at the start and in their usual spelling, so,
yes, I think it's better.
> I previously thought I should keep tree-conflicts branch stuff a little
> less loud, as in lower-case non-tagged, to not bother you with it.
>
(I'm going to assume that the word "you" is singular here.)
It's true that not everything should be tagged, but *if* you decide to
tag, then it helps everyone (including me) if you don't invent your own
tags.
> Thanks for your feedback!
> Neels
:)
Daniel
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: treeconflicts patch: cosmetic: another missing separator line.
Posted by Neels Janosch Hofmeyr <ne...@elego.de>.
Hi Daniel!
Daniel Shahaf wrote:
> 1. The patch is broken, your mailer ate the whitespace.
Sorry, my middle-mouse-button pasting must've messed something up.
>
> 2. Do you really need to send a patch for every missing separator line?
> Remember that not every typo, bad indentation, and strcmp()-that-violates-
> the-recommended-style (when we still had one) deserves a patch post. :)
True. kfogel, on the other hand, committed such a patch... I can't commit,
so I can only post changes or ignore them. I figured you'd just choose to
ignore the post. Should I just ignore these kinds of errors, instead?
>
> 3. Also, could you use tags properly in your subject lines? To me,
> "treeconflicts patch: cosmetic:" is three long words that I have to
> actually *read* :) (before I decide I'm not interested in the thread
> they're on), while the "[PATCH]" and "tree-conflicts" tags are
> comparatively easier to recognize.
So, a proper subject line for a patch destined for the tree-conflicts branch
should be
[PATCH] tree-conflicts: foo bar yada
? I previously thought I should keep tree-conflicts branch stuff a little
less loud, as in lower-case non-tagged, to not bother you with it.
Thanks for your feedback!
Neels
--
Neels Hofmeyr -- elego Software Solutions GmbH
Gustav-Meyer-Allee 25 / Gebäude 12, 13355 Berlin, Germany
phone: +49 30 23458696 mobile: +49 177 2345869 fax: +49 30 23458695
http://www.elegosoft.com | Geschäftsführer: Olaf Wagner | Sitz: Berlin
Handelsreg: Amtsgericht Charlottenburg HRB 77719 | USt-IdNr: DE163214194
Re: treeconflicts patch: cosmetic: another missing separator line.
Posted by Daniel Shahaf <d....@daniel.shahaf.name>.
1. The patch is broken, your mailer ate the whitespace.
2. Do you really need to send a patch for every missing separator line?
Remember that not every typo, bad indentation, and strcmp()-that-violates-
the-recommended-style (when we still had one) deserves a patch post. :)
3. Also, could you use tags properly in your subject lines? To me,
"treeconflicts patch: cosmetic:" is three long words that I have to
actually *read* :) (before I decide I'm not interested in the thread
they're on), while the "[PATCH]" and "tree-conflicts" tags are
comparatively easier to recognize.
Thanks,
Daniel
Neels Janosch Hofmeyr wrote on Thu, 21 Aug 2008 at 00:10 +0200:
> On the tree-conflicts branch only.
>
>
> [[[
> * subversion/tests/cmdline/merge_tests.py: Add a missing
> separator line.
> ]]]
>
>
> Index: subversion/tests/cmdline/merge_tests.py
> ===================================================================
> --- subversion/tests/cmdline/merge_tests.py (revision 32607)
> +++ subversion/tests/cmdline/merge_tests.py (working copy)
> @@ -12809,6 +12809,7 @@
> os.chdir(saved_cwd)
>
>
> +#----------------------------------------------------------------------
> # Helper for text output.
> def verify_lines(lines, regexes):
> """Return True if each of the given regular expressions matches
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org