You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/05/28 22:37:05 UTC
[GitHub] [dubbo-go-hessian2] wongoo opened a new pull request #195: merge for the release of v1.5.1
wongoo opened a new pull request #195:
URL: https://github.com/apache/dubbo-go-hessian2/pull/195
**What this PR does**:
- [Imp: add cache in reflection](#179)
- [Imp: decode string perf](#188)
- [Fix: fix get attachment lost nil key](#191)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-commenter edited a comment on pull request #195: merge for the release of v1.5.1
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #195:
URL: https://github.com/apache/dubbo-go-hessian2/pull/195#issuecomment-635645947
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=h1) Report
> Merging [#195](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=desc) into [1.5](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/e026b32f47d548e1d8051ac769364aa67678df3f&el=desc) will **decrease** coverage by `1.00%`.
> The diff coverage is `68.72%`.
[](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 1.5 #195 +/- ##
==========================================
- Coverage 67.42% 66.41% -1.01%
==========================================
Files 22 22
Lines 2671 2835 +164
==========================================
+ Hits 1801 1883 +82
- Misses 666 738 +72
- Partials 204 214 +10
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [decode.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-ZGVjb2RlLmdv) | `68.37% <53.84%> (-1.82%)` | :arrow_down: |
| [string.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-c3RyaW5nLmdv) | `57.91% <63.31%> (-10.23%)` | :arrow_down: |
| [object.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-b2JqZWN0Lmdv) | `66.25% <91.66%> (+1.64%)` | :arrow_up: |
| [pojo.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-cG9qby5nbw==) | `60.54% <100.00%> (+0.43%)` | :arrow_up: |
| [request.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-cmVxdWVzdC5nbw==) | `60.57% <100.00%> (+0.57%)` | :arrow_up: |
| [serialize.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-c2VyaWFsaXplLmdv) | `66.66% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=footer). Last update [e026b32...607925d](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-commenter edited a comment on pull request #195: merge for the release of v1.5.1
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #195:
URL: https://github.com/apache/dubbo-go-hessian2/pull/195#issuecomment-635645947
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=h1) Report
> Merging [#195](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=desc) into [1.5](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/e026b32f47d548e1d8051ac769364aa67678df3f&el=desc) will **decrease** coverage by `0.92%`.
> The diff coverage is `68.99%`.
[](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 1.5 #195 +/- ##
==========================================
- Coverage 67.42% 66.50% -0.93%
==========================================
Files 22 22
Lines 2671 2836 +165
==========================================
+ Hits 1801 1886 +85
- Misses 666 737 +71
- Partials 204 213 +9
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [decode.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-ZGVjb2RlLmdv) | `68.37% <53.84%> (-1.82%)` | :arrow_down: |
| [string.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-c3RyaW5nLmdv) | `57.91% <63.31%> (-10.23%)` | :arrow_down: |
| [object.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-b2JqZWN0Lmdv) | `66.97% <92.10%> (+2.36%)` | :arrow_up: |
| [pojo.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-cG9qby5nbw==) | `60.54% <100.00%> (+0.43%)` | :arrow_up: |
| [request.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-cmVxdWVzdC5nbw==) | `60.57% <100.00%> (+0.57%)` | :arrow_up: |
| [serialize.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-c2VyaWFsaXplLmdv) | `66.66% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=footer). Last update [e026b32...6e2b22b](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-commenter commented on pull request #195: merge for the release of v1.5.1
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #195:
URL: https://github.com/apache/dubbo-go-hessian2/pull/195#issuecomment-635645947
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=h1) Report
> Merging [#195](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=desc) into [1.5](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/df2a2402d25b5f162895c06d9fc34b6c0475dac3&el=desc) will **decrease** coverage by `1.41%`.
> The diff coverage is `63.51%`.
[](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 1.5 #195 +/- ##
==========================================
- Coverage 67.42% 66.01% -1.42%
==========================================
Files 22 22
Lines 2671 2845 +174
==========================================
+ Hits 1801 1878 +77
- Misses 666 749 +83
- Partials 204 218 +14
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [decode.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-ZGVjb2RlLmdv) | `66.66% <38.46%> (-3.53%)` | :arrow_down: |
| [string.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-c3RyaW5nLmdv) | `55.36% <57.71%> (-12.78%)` | :arrow_down: |
| [object.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-b2JqZWN0Lmdv) | `66.25% <91.66%> (+1.64%)` | :arrow_up: |
| [pojo.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-cG9qby5nbw==) | `60.54% <100.00%> (+0.43%)` | :arrow_up: |
| [request.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-cmVxdWVzdC5nbw==) | `60.57% <100.00%> (+0.57%)` | :arrow_up: |
| [serialize.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-c2VyaWFsaXplLmdv) | `66.66% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=footer). Last update [df2a240...9ab1067](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-commenter edited a comment on pull request #195: merge for the release of v1.5.1
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #195:
URL: https://github.com/apache/dubbo-go-hessian2/pull/195#issuecomment-635645947
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=h1) Report
> Merging [#195](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=desc) into [1.5](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/e026b32f47d548e1d8051ac769364aa67678df3f&el=desc) will **decrease** coverage by `0.92%`.
> The diff coverage is `68.97%`.
[](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 1.5 #195 +/- ##
==========================================
- Coverage 67.42% 66.50% -0.93%
==========================================
Files 22 22
Lines 2671 2851 +180
==========================================
+ Hits 1801 1896 +95
- Misses 666 741 +75
- Partials 204 214 +10
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [decode.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-ZGVjb2RlLmdv) | `68.37% <53.84%> (-1.82%)` | :arrow_down: |
| [string.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-c3RyaW5nLmdv) | `57.91% <63.31%> (-10.23%)` | :arrow_down: |
| [double.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-ZG91YmxlLmdv) | `86.15% <66.66%> (-5.85%)` | :arrow_down: |
| [object.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-b2JqZWN0Lmdv) | `66.97% <92.10%> (+2.36%)` | :arrow_up: |
| [encode.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-ZW5jb2RlLmdv) | `88.29% <100.00%> (ø)` | |
| [pojo.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-cG9qby5nbw==) | `60.54% <100.00%> (+0.43%)` | :arrow_up: |
| [request.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-cmVxdWVzdC5nbw==) | `60.57% <100.00%> (+0.57%)` | :arrow_up: |
| [serialize.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-c2VyaWFsaXplLmdv) | `66.66% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=footer). Last update [e026b32...4eb650b](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks commented on pull request #195: merge for the release of v1.5.1
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #195:
URL: https://github.com/apache/dubbo-go-hessian2/pull/195#issuecomment-635712618
pls wait for the next week. the ut coverage decreases now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] wongoo merged pull request #195: merge for the release of v1.6.0
Posted by GitBox <gi...@apache.org>.
wongoo merged pull request #195:
URL: https://github.com/apache/dubbo-go-hessian2/pull/195
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-commenter edited a comment on pull request #195: merge for the release of v1.5.1
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #195:
URL: https://github.com/apache/dubbo-go-hessian2/pull/195#issuecomment-635645947
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=h1) Report
> Merging [#195](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=desc) into [1.5](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/e026b32f47d548e1d8051ac769364aa67678df3f&el=desc) will **decrease** coverage by `1.03%`.
> The diff coverage is `68.24%`.
[](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 1.5 #195 +/- ##
==========================================
- Coverage 67.42% 66.39% -1.04%
==========================================
Files 22 22
Lines 2671 2845 +174
==========================================
+ Hits 1801 1889 +88
- Misses 666 740 +74
- Partials 204 216 +12
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [decode.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-ZGVjb2RlLmdv) | `68.37% <53.84%> (-1.82%)` | :arrow_down: |
| [string.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-c3RyaW5nLmdv) | `57.97% <62.85%> (-10.17%)` | :arrow_down: |
| [object.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-b2JqZWN0Lmdv) | `66.25% <91.66%> (+1.64%)` | :arrow_up: |
| [pojo.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-cG9qby5nbw==) | `60.54% <100.00%> (+0.43%)` | :arrow_up: |
| [request.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-cmVxdWVzdC5nbw==) | `60.57% <100.00%> (+0.57%)` | :arrow_up: |
| [serialize.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-c2VyaWFsaXplLmdv) | `66.66% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=footer). Last update [e026b32...7bcae39](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-commenter edited a comment on pull request #195: merge for the release of v1.5.1
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #195:
URL: https://github.com/apache/dubbo-go-hessian2/pull/195#issuecomment-635645947
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=h1) Report
> Merging [#195](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=desc) into [1.5](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/e026b32f47d548e1d8051ac769364aa67678df3f&el=desc) will **decrease** coverage by `1.03%`.
> The diff coverage is `68.24%`.
[](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 1.5 #195 +/- ##
==========================================
- Coverage 67.42% 66.39% -1.04%
==========================================
Files 22 22
Lines 2671 2845 +174
==========================================
+ Hits 1801 1889 +88
- Misses 666 740 +74
- Partials 204 216 +12
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [decode.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-ZGVjb2RlLmdv) | `68.37% <53.84%> (-1.82%)` | :arrow_down: |
| [string.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-c3RyaW5nLmdv) | `57.97% <62.85%> (-10.17%)` | :arrow_down: |
| [object.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-b2JqZWN0Lmdv) | `66.25% <91.66%> (+1.64%)` | :arrow_up: |
| [pojo.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-cG9qby5nbw==) | `60.54% <100.00%> (+0.43%)` | :arrow_up: |
| [request.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-cmVxdWVzdC5nbw==) | `60.57% <100.00%> (+0.57%)` | :arrow_up: |
| [serialize.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-c2VyaWFsaXplLmdv) | `66.66% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=footer). Last update [e026b32...7bcae39](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-commenter edited a comment on pull request #195: merge for the release of v1.5.1
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #195:
URL: https://github.com/apache/dubbo-go-hessian2/pull/195#issuecomment-635645947
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=h1) Report
> Merging [#195](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=desc) into [1.5](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/e026b32f47d548e1d8051ac769364aa67678df3f&el=desc) will **decrease** coverage by `0.92%`.
> The diff coverage is `68.99%`.
[](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 1.5 #195 +/- ##
==========================================
- Coverage 67.42% 66.50% -0.93%
==========================================
Files 22 22
Lines 2671 2836 +165
==========================================
+ Hits 1801 1886 +85
- Misses 666 737 +71
- Partials 204 213 +9
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [decode.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-ZGVjb2RlLmdv) | `68.37% <53.84%> (-1.82%)` | :arrow_down: |
| [string.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-c3RyaW5nLmdv) | `57.91% <63.31%> (-10.23%)` | :arrow_down: |
| [object.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-b2JqZWN0Lmdv) | `66.97% <92.10%> (+2.36%)` | :arrow_up: |
| [pojo.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-cG9qby5nbw==) | `60.54% <100.00%> (+0.43%)` | :arrow_up: |
| [request.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-cmVxdWVzdC5nbw==) | `60.57% <100.00%> (+0.57%)` | :arrow_up: |
| [serialize.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-c2VyaWFsaXplLmdv) | `66.66% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=footer). Last update [e026b32...6e2b22b](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-commenter edited a comment on pull request #195: merge for the release of v1.6.0
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #195:
URL: https://github.com/apache/dubbo-go-hessian2/pull/195#issuecomment-635645947
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=h1) Report
> Merging [#195](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=desc) into [1.6](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/e026b32f47d548e1d8051ac769364aa67678df3f&el=desc) will **decrease** coverage by `0.92%`.
> The diff coverage is `68.97%`.
[](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 1.6 #195 +/- ##
==========================================
- Coverage 67.42% 66.50% -0.93%
==========================================
Files 22 22
Lines 2671 2851 +180
==========================================
+ Hits 1801 1896 +95
- Misses 666 741 +75
- Partials 204 214 +10
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [decode.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-ZGVjb2RlLmdv) | `68.37% <53.84%> (-1.82%)` | :arrow_down: |
| [string.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-c3RyaW5nLmdv) | `57.91% <63.31%> (-10.23%)` | :arrow_down: |
| [double.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-ZG91YmxlLmdv) | `86.15% <66.66%> (-5.85%)` | :arrow_down: |
| [object.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-b2JqZWN0Lmdv) | `66.97% <92.10%> (+2.36%)` | :arrow_up: |
| [encode.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-ZW5jb2RlLmdv) | `88.29% <100.00%> (ø)` | |
| [pojo.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-cG9qby5nbw==) | `60.54% <100.00%> (+0.43%)` | :arrow_up: |
| [request.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-cmVxdWVzdC5nbw==) | `60.57% <100.00%> (+0.57%)` | :arrow_up: |
| [serialize.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-c2VyaWFsaXplLmdv) | `66.66% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=footer). Last update [e026b32...025ccae](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-commenter edited a comment on pull request #195: merge for the release of v1.6.0
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #195:
URL: https://github.com/apache/dubbo-go-hessian2/pull/195#issuecomment-635645947
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=h1) Report
> Merging [#195](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=desc) into [1.6](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/e026b32f47d548e1d8051ac769364aa67678df3f&el=desc) will **decrease** coverage by `0.92%`.
> The diff coverage is `68.97%`.
[](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 1.6 #195 +/- ##
==========================================
- Coverage 67.42% 66.50% -0.93%
==========================================
Files 22 22
Lines 2671 2851 +180
==========================================
+ Hits 1801 1896 +95
- Misses 666 741 +75
- Partials 204 214 +10
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [decode.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-ZGVjb2RlLmdv) | `68.37% <53.84%> (-1.82%)` | :arrow_down: |
| [string.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-c3RyaW5nLmdv) | `57.91% <63.31%> (-10.23%)` | :arrow_down: |
| [double.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-ZG91YmxlLmdv) | `86.15% <66.66%> (-5.85%)` | :arrow_down: |
| [object.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-b2JqZWN0Lmdv) | `66.97% <92.10%> (+2.36%)` | :arrow_up: |
| [encode.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-ZW5jb2RlLmdv) | `88.29% <100.00%> (ø)` | |
| [pojo.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-cG9qby5nbw==) | `60.54% <100.00%> (+0.43%)` | :arrow_up: |
| [request.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-cmVxdWVzdC5nbw==) | `60.57% <100.00%> (+0.57%)` | :arrow_up: |
| [serialize.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-c2VyaWFsaXplLmdv) | `66.66% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=footer). Last update [e026b32...9cd3b94](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] fangyincheng commented on pull request #195: merge for the release of v1.5.1
Posted by GitBox <gi...@apache.org>.
fangyincheng commented on pull request #195:
URL: https://github.com/apache/dubbo-go-hessian2/pull/195#issuecomment-639303276
decrease 10% in string.go？
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-commenter edited a comment on pull request #195: merge for the release of v1.5.1
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #195:
URL: https://github.com/apache/dubbo-go-hessian2/pull/195#issuecomment-635645947
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=h1) Report
> Merging [#195](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=desc) into [1.5](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/e026b32f47d548e1d8051ac769364aa67678df3f&el=desc) will **decrease** coverage by `1.03%`.
> The diff coverage is `68.24%`.
[](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 1.5 #195 +/- ##
==========================================
- Coverage 67.42% 66.39% -1.04%
==========================================
Files 22 22
Lines 2671 2845 +174
==========================================
+ Hits 1801 1889 +88
- Misses 666 740 +74
- Partials 204 216 +12
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [decode.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-ZGVjb2RlLmdv) | `68.37% <53.84%> (-1.82%)` | :arrow_down: |
| [string.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-c3RyaW5nLmdv) | `57.97% <62.85%> (-10.17%)` | :arrow_down: |
| [object.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-b2JqZWN0Lmdv) | `66.25% <91.66%> (+1.64%)` | :arrow_up: |
| [pojo.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-cG9qby5nbw==) | `60.54% <100.00%> (+0.43%)` | :arrow_up: |
| [request.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-cmVxdWVzdC5nbw==) | `60.57% <100.00%> (+0.57%)` | :arrow_up: |
| [serialize.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195/diff?src=pr&el=tree#diff-c2VyaWFsaXplLmdv) | `66.66% <100.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=footer). Last update [e026b32...f7b44b5](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/195?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org