[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2509: bsp/stm32f4discovery: Add UART_1 support to enable logging using the ST-LINK virtual COM port

[GitBox <gi...@apache.org>]

apache-mynewt-bot commented on pull request #2509:
URL: https://github.com/apache/mynewt-core/pull/2509#issuecomment-787503846


   
   <!-- style-bot -->
   
   ## Style check summary
   
   ### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
   
   
   #### hw/bsp/stm32f4discovery/src/hal_bsp.c
   <details>
   
   ```diff
   @@ -73,9 +73,11 @@
    #endif
    
    #if MYNEWT_VAL(UART_1)
   -// If flying wires are connected as in the discovery kit user manual
   -// (Figure 6. ST-LINK VCP connection to USART2), logging via the ST-LINK
   -// virtual COM port can be achieved by setting CONSOLE_UART_DEV to uart1.
   +/*
   +   If flying wires are connected as in the discovery kit user manual
   +   (Figure 6. ST-LINK VCP connection to USART2), logging via the ST-LINK
   +   virtual COM port can be achieved by setting CONSOLE_UART_DEV to uart1.
   + */
    const struct stm32_uart_cfg os_bsp_uart1_cfg = {
        .suc_uart = USART2,
        .suc_rcc_reg = &RCC->APB1ENR,
   ```
   
   </details>


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org