Re: [PR] feat(viz: country-map): Add support for region normalization to country map [superset]

["mistercrunch (via GitHub)" <gi...@apache.org>]

mistercrunch commented on code in PR #32300:
URL: https://github.com/apache/superset/pull/32300#discussion_r1960520175


##########
superset-frontend/plugins/legacy-plugin-chart-country-map/src/CountryMap.js:
##########
@@ -37,7 +37,6 @@ const propTypes = {
   width: PropTypes.number,
   height: PropTypes.number,
   country: PropTypes.string,
-  colorScheme: PropTypes.string,

Review Comment:
   Do we not support categorical use cases here? I forgot the details, but I think there was a way to use this visualization to show categorical classification in some cases. Like plotting categorical for something like "most grown crop" on a per-state basis.
   
   Seems the color scheme related changes here don't align with the title/body of the PR (which is about iso code support)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org