You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by jm...@apache.org on 2022/01/14 17:15:16 UTC

[datasketches-cpp] branch quantiles updated: add missing header, fix comparator usage

This is an automated email from the ASF dual-hosted git repository.

jmalkin pushed a commit to branch quantiles
in repository https://gitbox.apache.org/repos/asf/datasketches-cpp.git


The following commit(s) were added to refs/heads/quantiles by this push:
     new f0d1a6e  add missing header, fix comparator usage
f0d1a6e is described below

commit f0d1a6ecd8cc235e66874ecea0e0d90374cda678
Author: Jon Malkin <jm...@users.noreply.github.com>
AuthorDate: Fri Jan 14 09:15:09 2022 -0800

    add missing header, fix comparator usage
---
 quantiles/include/quantiles_sketch_impl.hpp | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/quantiles/include/quantiles_sketch_impl.hpp b/quantiles/include/quantiles_sketch_impl.hpp
index 5e1bbfc..06d7df9 100644
--- a/quantiles/include/quantiles_sketch_impl.hpp
+++ b/quantiles/include/quantiles_sketch_impl.hpp
@@ -23,6 +23,7 @@
 #include <cmath>
 #include <algorithm>
 #include <stdexcept>
+#include <iomanip>
 
 #include "common_defs.hpp"
 #include "count_zeros.hpp"
@@ -563,7 +564,7 @@ void quantiles_sketch<T, C, S, A>::merge_two_size_k_buffers(Level& src_1, Level&
   
   // TODO: probably actually doing copies given Level&?
   while (it1 != end1 && it2 != end2) {
-    if (C()(*it1, *it2) < 0) {
+    if (C()(*it1, *it2)) {
       dst.push_back(std::move(*it2++));
     } else {
       dst.push_back(std::move(*it1++));

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org