You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tuscany.apache.org by mc...@apache.org on 2008/05/20 15:07:14 UTC

svn commit: r658230 - /incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/PolicyConfigurationUtil.java

Author: mcombellack
Date: Tue May 20 06:07:14 2008
New Revision: 658230

URL: http://svn.apache.org/viewvc?rev=658230&view=rev
Log:
The original code was creating exceptions but not actually throwing them when the errors occurred. Updated the code to actually throw the exceptions that are created (FindBugs reported issue)

Modified:
    incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/PolicyConfigurationUtil.java

Modified: incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/PolicyConfigurationUtil.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/PolicyConfigurationUtil.java?rev=658230&r1=658229&r2=658230&view=diff
==============================================================================
--- incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/PolicyConfigurationUtil.java (original)
+++ incubator/tuscany/java/sca/modules/assembly/src/main/java/org/apache/tuscany/sca/assembly/builder/impl/PolicyConfigurationUtil.java Tue May 20 06:07:14 2008
@@ -508,7 +508,7 @@
                                                             policiedBinding.getType());
     
                         if (confOp.getRequiredIntents().size() > 0) {
-                            new PolicyConfigurationException("The following are unfulfilled intents for operations configured in "
+                            throw new PolicyConfigurationException("The following are unfulfilled intents for operations configured in "
                                     + "binding - " + aBinding.getName() + "\nUnfulfilled Intents = " +
                                     confOp.getRequiredIntents());
                         }
@@ -711,7 +711,7 @@
                                                         policiedImplementation.getType());
     
                     if (confOp.getRequiredIntents().size() > 0) {
-                        new PolicyConfigurationException("The following are unfulfilled intents for operations configured in "
+                        throw new PolicyConfigurationException("The following are unfulfilled intents for operations configured in "
                                 + "component implementation - " + component.getName() + "\nUnfulfilled Intents = " +
                                 confOp.getRequiredIntents());
                     }