You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2023/01/12 14:32:57 UTC
[GitHub] [airflow] IAL32 opened a new issue, #28888: `webserver.instance_name` shows markup text in `` tag</h1><pre>
IAL32 opened a new issue, #28888:
URL: https://github.com/apache/airflow/issues/28888
### Apache Airflow version
2.5.0
### What happened
https://github.com/apache/airflow/pull/20888 enables the use of markup to style the `webserver.instance_name`.
However, if the instance name has HTML code, this will also be reflected in the `<title>` tag, as shown in the screenshot below.
This is not a pretty behaviour.
### What you think should happen instead
Ideally, if `webserver. instance_name_has_markup = True`, then the text inside the `<title>` should be stripped of HTML code.
For example:
- Set `webserver.instance_name` to some text with markup, like `<b style="color: red">title</b>`
- Set `webserver.Instance_name_has_markup` to `true`
This is how the `<title>` tag should look like:
```html
<title>DAGs - title</title>
```
Instead of:
```
<title>DAGs - <b style="color: red">title<b></title>
```
### How to reproduce
- Airflow version 2.3+, which is [when this change has been introduced](https://airflow.apache.org/docs/apache-airflow/stable/configurations-ref.html#instance-name-has-markup)
- Set `webserver.instance_name` to some text with markup, like `<b style="color: red">title</b>`
- Set `webserver.Instance_name_has_markup` to `true`
### Operating System
Doesn't matter
### Versions of Apache Airflow Providers
_No response_
### Deployment
Other
### Deployment details
_No response_
### Anything else
_No response_
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
</pre><hr/>
<h2>[GitHub] [airflow] amoghrajesh commented on issue #28888: `webserver.instance_name` shows markup text in `<title>` tag</h2>
<b>Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.</b><hr/><pre>
amoghrajesh commented on issue #28888:
URL: https://github.com/apache/airflow/issues/28888#issuecomment-1465528064
@IAL32 are you actively working on this? I see the PR was not merged. I can take it forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
</pre><hr/>
<h2>[GitHub] [airflow] IAL32 commented on issue #28888: `webserver.instance_name` shows markup text in `<title>` tag</h2>
<b>Posted by "IAL32 (via GitHub)" <gi...@apache.org>.</b><hr/><pre>
IAL32 commented on issue #28888:
URL: https://github.com/apache/airflow/issues/28888#issuecomment-1469435817
@amoghrajesh hello there! I mean, the PR https://github.com/apache/airflow/pull/28894 is ready, so there is not much to bring forward unfortunately 😅 feel free to pitch in, though!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
</pre><hr/>
<h2>[GitHub] [airflow] boring-cyborg[bot] commented on issue #28888: `webserver.instance_name` shows markup text in `<title>` tag</h2>
<b>Posted by GitBox <gi...@apache.org>.</b><hr/><pre>
boring-cyborg[bot] commented on issue #28888:
URL: https://github.com/apache/airflow/issues/28888#issuecomment-1380450552
Thanks for opening your first issue here! Be sure to follow the issue template!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
</pre><hr/>
<h2>[GitHub] [airflow] potiuk commented on issue #28888: `webserver.instance_name` shows markup text in `<title>` tag</h2>
<b>Posted by "potiuk (via GitHub)" <gi...@apache.org>.</b><hr/><pre>
potiuk commented on issue #28888:
URL: https://github.com/apache/airflow/issues/28888#issuecomment-1468963141
Assigned you @amoghrajesh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
</pre><hr/>
<h2>[GitHub] [airflow] uranusjr closed issue #28888: `webserver.instance_name` shows markup text in `<title>` tag</h2>
<b>Posted by "uranusjr (via GitHub)" <gi...@apache.org>.</b><hr/><pre>
uranusjr closed issue #28888: `webserver.instance_name` shows markup text in `<title>` tag
URL: https://github.com/apache/airflow/issues/28888
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
</pre><hr/>
</body>
</html>