You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/26 00:55:57 UTC

[GitHub] [incubator-nuttx-apps] masayuki2009 opened a new pull request #982: Makefile, import/Make.defs: Fix undefined symbols for CONFIG_BUILD_KERNEL=y

masayuki2009 opened a new pull request #982:
URL: https://github.com/apache/incubator-nuttx-apps/pull/982


   ## Summary
   
   - I noticed that applications made by 'make import' contain
     undefined symbols such as printf for CONFIG_BUILD_KERNEL=y
   - This commit fixes this issue by adding user libraries.
   - Also, this commit generates libapps.a which is used for init
   
   ## Impact
   
   - CONFIG_BUILD_KERNEL=y only
   
   ## Testing
   
   - Build (mkimport, make import) with sama5d4-ek:knsh
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #982: Makefile, import/Make.defs: Fix undefined symbols for CONFIG_BUILD_KERNEL=y

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #982:
URL: https://github.com/apache/incubator-nuttx-apps/pull/982#issuecomment-1021833025


   Let me re-run all the jobs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] pkarashchenko commented on a change in pull request #982: Makefile, import/Make.defs: Fix undefined symbols for CONFIG_BUILD_KERNEL=y

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on a change in pull request #982:
URL: https://github.com/apache/incubator-nuttx-apps/pull/982#discussion_r792259532



##########
File path: import/Make.defs
##########
@@ -74,6 +74,12 @@ else
   LDLIBPATH = -L $(TOPDIR)$(DELIM)libs
 endif
 
+# Link with user libraries
+
+ifeq ($(CONFIG_BUILD_KERNEL),y)
+LDLIBS = -lapps -lxx -lmm -lc -lm -lproxies

Review comment:
       ```suggestion
     LDLIBS = -lapps -lxx -lmm -lc -lm -lproxies
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #982: Makefile, import/Make.defs: Fix undefined symbols for CONFIG_BUILD_KERNEL=y

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #982:
URL: https://github.com/apache/incubator-nuttx-apps/pull/982#discussion_r792970925



##########
File path: Makefile
##########
@@ -63,6 +63,10 @@ ifeq ($(CONFIG_BUILD_KERNEL),y)
 install: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_install)
 
 .import: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_all)
+	$(Q) for app in ${CONFIGURED_APPS}; do \
+		$(MAKE) -C "$${app}" archive ; \

Review comment:
       But, I can't find archive target from the top Makefile or Application.mk.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on a change in pull request #982: Makefile, import/Make.defs: Fix undefined symbols for CONFIG_BUILD_KERNEL=y

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on a change in pull request #982:
URL: https://github.com/apache/incubator-nuttx-apps/pull/982#discussion_r793167374



##########
File path: Makefile
##########
@@ -63,6 +63,10 @@ ifeq ($(CONFIG_BUILD_KERNEL),y)
 install: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_install)
 
 .import: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_all)
+	$(Q) for app in ${CONFIGURED_APPS}; do \
+		$(MAKE) -C "$${app}" archive ; \

Review comment:
       > But, I can't find archive target from the top Makefile or Application.mk.
   
   @xiaoxiang781216 
   You can find the target at
   https://github.com/apache/incubator-nuttx-apps/blob/3c556384ea685ebb12d3c6cb7f1c34c07b4d2015/Application.mk#L144
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 commented on a change in pull request #982: Makefile, import/Make.defs: Fix undefined symbols for CONFIG_BUILD_KERNEL=y

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #982:
URL: https://github.com/apache/incubator-nuttx-apps/pull/982#discussion_r792278983



##########
File path: Makefile
##########
@@ -63,6 +63,10 @@ ifeq ($(CONFIG_BUILD_KERNEL),y)
 install: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_install)
 
 .import: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_all)
+	$(Q) for app in ${CONFIGURED_APPS}; do \
+		$(MAKE) -C "$${app}" archive ; \

Review comment:
       archive isn't a general target, why we need this?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on pull request #982: Makefile, import/Make.defs: Fix undefined symbols for CONFIG_BUILD_KERNEL=y

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on pull request #982:
URL: https://github.com/apache/incubator-nuttx-apps/pull/982#issuecomment-1021829817


   Hmm, I don't know why 'Build / Linux (risc-v)' failed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on a change in pull request #982: Makefile, import/Make.defs: Fix undefined symbols for CONFIG_BUILD_KERNEL=y

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on a change in pull request #982:
URL: https://github.com/apache/incubator-nuttx-apps/pull/982#discussion_r792261630



##########
File path: import/Make.defs
##########
@@ -74,6 +74,12 @@ else
   LDLIBPATH = -L $(TOPDIR)$(DELIM)libs
 endif
 
+# Link with user libraries
+
+ifeq ($(CONFIG_BUILD_KERNEL),y)
+LDLIBS = -lapps -lxx -lmm -lc -lm -lproxies

Review comment:
       done
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] masayuki2009 commented on a change in pull request #982: Makefile, import/Make.defs: Fix undefined symbols for CONFIG_BUILD_KERNEL=y

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on a change in pull request #982:
URL: https://github.com/apache/incubator-nuttx-apps/pull/982#discussion_r792291485



##########
File path: Makefile
##########
@@ -63,6 +63,10 @@ ifeq ($(CONFIG_BUILD_KERNEL),y)
 install: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_install)
 
 .import: $(foreach SDIR, $(CONFIGURED_APPS), $(SDIR)_all)
+	$(Q) for app in ${CONFIGURED_APPS}; do \
+		$(MAKE) -C "$${app}" archive ; \

Review comment:
       @xiaoxiang781216 
   We need the archive target to generate libapps.a which is used for the init (the nsh)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] masayuki2009 edited a comment on pull request #982: Makefile, import/Make.defs: Fix undefined symbols for CONFIG_BUILD_KERNEL=y

Posted by GitBox <gi...@apache.org>.
masayuki2009 edited a comment on pull request #982:
URL: https://github.com/apache/incubator-nuttx-apps/pull/982#issuecomment-1021829817


   Hmm, I don't know why 'Build / Linux (risc-v)' failed.
   
   ```
   unzip:  cannot find zipfile directory in one of chip/v1.9.1-ble-test.zip or
           chip/v1.9.1-ble-test.zip.zip, and cannot find chip/v1.9.1-ble-test.zip.ZIP, period.
   make[1]: *** [chip/Make.defs:102: chip/bl_blob] Error 9
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-nuttx-apps] xiaoxiang781216 merged pull request #982: Makefile, import/Make.defs: Fix undefined symbols for CONFIG_BUILD_KERNEL=y

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #982:
URL: https://github.com/apache/incubator-nuttx-apps/pull/982


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org