[GitHub] [beam] echauchot commented on pull request #15529: [BEAM-12849] Add gradle runtimeOnly scope to spark deps so that local in memory runs like nexmark could have the spark libs in the runtime classpath

[GitBox <gi...@apache.org>]

echauchot commented on pull request #15529:
URL: https://github.com/apache/beam/pull/15529#issuecomment-932023808


   > It would make a lot more sense to repeat the existing pattern where we add the necessary deps to the nexmark run as we do for spark 2 with `shouldProvideSpark`:
   > 
   > https://github.com/apache/beam/blob/e5ac1ae1c0ba1a682b2ace4ebdae8e4a1b5f8716/sdks/java/testing/nexmark/build.gradle#L41
   > 
   > 
   > and add the deps here:
   > https://github.com/apache/beam/blob/e5ac1ae1c0ba1a682b2ace4ebdae8e4a1b5f8716/sdks/java/testing/nexmark/build.gradle#L96
   > 
   > 
   > since this change is about running nexmark on spark.
   > This will keep the same pattern used in nexmark and other integration tests.
   
   Thanks @lukecwik for the suggestion ! I totally agree, I was just not aware of this part of the conf !
   If in the future it is needed for somewhere else than Nexmark, we will use the same pattern again.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org