[GitHub] [incubator-nuttx] curuvar commented on a diff in pull request #6648: Added Adafruit QT Py RP2040 board and made UART, SPI, and I2C configuration more flexible.

[GitBox <gi...@apache.org>]

curuvar commented on code in PR #6648:
URL: https://github.com/apache/incubator-nuttx/pull/6648#discussion_r926545372


##########
arch/arm/src/rp2040/Kconfig:
##########
@@ -13,9 +20,63 @@ config RP2040_UART0
 
 if RP2040_UART0
 
+config RP2040_UART0_TX_GPIO

Review Comment:
   I'm open to doing this.  
   
   Currently a user must go the the "arch" options to turn on UART0, but then go to a completely different menu to configure the UART.  This seems wrong to me.  My goal was to keep all the pin configuration options in the same place within the menuconfig structure and since the pins are a feature of the RP2040 chip itself, it seemed better to do that in "arch" rather than "board".
   
   If you think that all these configuration options would be better placed under the "board" menu, I'll move them all there.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org