You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/11/03 10:28:06 UTC
[GitHub] [apisix-helm-chart] tokers opened a new pull request #175: feat: support more APISIX features
tokers opened a new pull request #175:
URL: https://github.com/apache/apisix-helm-chart/pull/175
Signed-off-by: Chao Zhang <to...@apache.org>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on pull request #175: feat: support more APISIX features
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on pull request #175:
URL: https://github.com/apache/apisix-helm-chart/pull/175#issuecomment-962783031
Please also update the document to introduce these configuration items, and then we can merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on a change in pull request #175: feat: support more APISIX features
Posted by GitBox <gi...@apache.org>.
tao12345666333 commented on a change in pull request #175:
URL: https://github.com/apache/apisix-helm-chart/pull/175#discussion_r742514044
##########
File path: charts/apisix/values.yaml
##########
@@ -186,6 +188,8 @@ stream_plugins:
- ip-restriction
- limit-conn
+pluginAttrs: null
Review comment:
Its type should be array, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 merged pull request #175: feat: support more APISIX features
Posted by GitBox <gi...@apache.org>.
tao12345666333 merged pull request #175:
URL: https://github.com/apache/apisix-helm-chart/pull/175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #175: feat: support more APISIX features
Posted by GitBox <gi...@apache.org>.
tokers commented on a change in pull request #175:
URL: https://github.com/apache/apisix-helm-chart/pull/175#discussion_r742692988
##########
File path: charts/apisix/values.yaml
##########
@@ -186,6 +188,8 @@ stream_plugins:
- ip-restriction
- limit-conn
+pluginAttrs: null
Review comment:
It's a map, let me to change to `{}`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on pull request #175: feat: support more APISIX features
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #175:
URL: https://github.com/apache/apisix-helm-chart/pull/175#issuecomment-984490474
> Please also update the document to introduce these configuration items, and then we can merge.
Added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org