You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/17 12:11:11 UTC

[GitHub] [inlong] haifxu opened a new pull request, #5586: [INLONG-5582][Manager] Fix error in client API

haifxu opened a new pull request, #5586:
URL: https://github.com/apache/inlong/pull/5586

   - Fixes #5582 
   
   ### Motivation
   
   Fix errors of inlong stream API and user API.
   
   ### Modifications
   
   1.Remove `/`.
   
   2.Use `MAP` instead of object.
   
   ### Verifying this change
   
   - [ ] This change is a trivial rework/code cleanup without any test coverage.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] haifxu commented on a diff in pull request #5586: [INLONG-5582][Manager] Fix error in client API

Posted by GitBox <gi...@apache.org>.
haifxu commented on code in PR #5586:
URL: https://github.com/apache/inlong/pull/5586#discussion_r948817123


##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/service/UserApi.java:
##########
@@ -41,7 +43,7 @@ public interface UserApi {
     Call<Response<UserInfo>> getById(@Path("id") Integer id);
 
     @GET("user/listAll")
-    Call<Response<PageInfo<UserInfo>>> list(UserRequest request);
+    Call<Response<PageInfo<UserInfo>>> list(@Query("request") Map<String, Object> request);

Review Comment:
   Done.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow merged pull request #5586: [INLONG-5582][Manager][Dashboard] Fix error in client API

Posted by GitBox <gi...@apache.org>.
healchow merged PR #5586:
URL: https://github.com/apache/inlong/pull/5586


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [inlong] healchow commented on a diff in pull request #5586: [INLONG-5582][Manager] Fix error in client API

Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #5586:
URL: https://github.com/apache/inlong/pull/5586#discussion_r948669891


##########
inlong-manager/manager-client/src/main/java/org/apache/inlong/manager/client/api/service/UserApi.java:
##########
@@ -41,7 +43,7 @@ public interface UserApi {
     Call<Response<UserInfo>> getById(@Path("id") Integer id);
 
     @GET("user/listAll")
-    Call<Response<PageInfo<UserInfo>>> list(UserRequest request);
+    Call<Response<PageInfo<UserInfo>>> list(@Query("request") Map<String, Object> request);

Review Comment:
   Suggested changing to POST method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org