[jira] [Created] (OPTIQ-306) Standardize code style for "import package.*;"

["Julian Hyde (JIRA)" <ji...@apache.org>]

Julian Hyde created OPTIQ-306:
---------------------------------

             Summary: Standardize code style for "import package.*;"
                 Key: OPTIQ-306
                 URL: https://issues.apache.org/jira/browse/OPTIQ-306
             Project: optiq
          Issue Type: Improvement
            Reporter: Julian Hyde
            Assignee: Julian Hyde
            Priority: Trivial


Our house style does not specify whether/when imports are to be converted to stars. I propose that imports should be converted to stars if there are more than 3 from the same package. Thus:

{code}
import a.b.C1;
import a.b.C2;
import a.b.C3;
{code}

becomes

{code}
import a.b.*;
{code}

when {{a.b.C4}} is added. This is consistent with IntelliJ's default rule.

It is OK to use stars if there are 3 or fewer uses. Thus removing the use of {{a.b.C2}} would not require imports to be changed.

Checkstyle has a rule to ban star imports (excluding certain packages) but does not allow them to be limited to a particular number.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Re: [jira] [Created] (OPTIQ-306) Standardize code style for "import package.*;"

[Jacques Nadeau <ja...@apache.org>]

I find explicit much better. Makes it clear exactly what is required. Merge
conflicts are trivial to solve and assessing refactoring is substantially
easier.
On Jun 20, 2014 3:08 PM, "Julian Hyde (JIRA)" <ji...@apache.org> wrote:

> Julian Hyde created OPTIQ-306:
> ---------------------------------
>
>              Summary: Standardize code style for "import package.*;"
>                  Key: OPTIQ-306
>                  URL: https://issues.apache.org/jira/browse/OPTIQ-306
>              Project: optiq
>           Issue Type: Improvement
>             Reporter: Julian Hyde
>             Assignee: Julian Hyde
>             Priority: Trivial
>
>
> Our house style does not specify whether/when imports are to be converted
> to stars. I propose that imports should be converted to stars if there are
> more than 3 from the same package. Thus:
>
> {code}
> import a.b.C1;
> import a.b.C2;
> import a.b.C3;
> {code}
>
> becomes
>
> {code}
> import a.b.*;
> {code}
>
> when {{a.b.C4}} is added. This is consistent with IntelliJ's default rule.
>
> It is OK to use stars if there are 3 or fewer uses. Thus removing the use
> of {{a.b.C2}} would not require imports to be changed.
>
> Checkstyle has a rule to ban star imports (excluding certain packages) but
> does not allow them to be limited to a particular number.
>
>
>
> --
> This message was sent by Atlassian JIRA
> (v6.2#6252)
>